fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-04 22:49:13 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

zink: remove needless requirements

Browse source 
We never required the uniform texel buffer bit for more than
bufferFeatures for a bunch of these formats.

Similarly, we *don't* need the uniform texel buffer bit for sampled
image access.

For the image-dimensions, the Mesa frontend doesn't validate the max 1D,
3D or Cube sizes, nor the max texture layers. So we'll expose GL 4.1
without these, even if that's not conformant.

Finally, we don't require robustImageAccess2 for OpenGL 4.3 at all. All
we need is the robustBufferAccess feature.

Fixes: 2ea481b2f0 ("Zink: add Zink profiles file")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/19779>
(cherry picked from commit b60bc52992)
This commit is contained in:
Erik Faye-Lund 2022-11-16 12:41:07 +01:00 • committed by Eric Engestrom
parent 394d7edb4f
commit e58d22220a
2 changed files with 1 additions and 56 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1750,7 +1750,7 @@
"description": "zink: remove needless requirements",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "2ea481b2f0a8afbdf7bb510ff11497535083c424"
},

55
src/gallium/drivers/zink/VP_ZINK_requirements.json
View file

@ -124,12 +124,6 @@
"formats": {
"VK_FORMAT_R32G32B32_SFLOAT": {
"VkFormatProperties": {
"linearTilingFeatures": [
"VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT"
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT"
]
@ -137,12 +131,6 @@
},
"VK_FORMAT_R32G32B32_SINT": {
"VkFormatProperties": {
"linearTilingFeatures": [
"VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT"
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT"
]
@ -150,12 +138,6 @@
},
"VK_FORMAT_R32G32B32_UINT": {
"VkFormatProperties": {
"linearTilingFeatures": [
"VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT"
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_UNIFORM_TEXEL_BUFFER_BIT"
]
@ -172,11 +154,7 @@
"properties": {
"VkPhysicalDeviceProperties": {
"limits": {
"maxImageDimension1D": 16384,
"maxImageDimension2D": 16384,
"maxImageDimension3D": 2048,
"maxImageDimensionCube": 16384,
"maxImageArrayLayers": 2048,
"maxViewports": 16
}
}
@ -214,16 +192,10 @@
}
},
"gl43_baseline": {
"extensions": {
"VK_EXT_robustness2": 1
},
"features": {
"VkPhysicalDeviceFeatures": {
"robustBufferAccess": true,
"multiDrawIndirect": true
},
"VkPhysicalDeviceRobustness2FeaturesEXT": {
"robustImageAccess2": true
}
},
"formats": {
@ -234,9 +206,6 @@
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
]
}
},
@ -247,9 +216,6 @@
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
]
}
},
@ -260,9 +226,6 @@
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
]
}
},
@ -273,9 +236,6 @@
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
]
}
},
@ -286,9 +246,6 @@
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
]
}
},
@ -299,9 +256,6 @@
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
]
}
},
@ -312,9 +266,6 @@
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_SAMPLED_IMAGE_BIT"
]
}
}
@ -327,12 +278,6 @@
"formats": {
"VK_FORMAT_B10G11R11_UFLOAT_PACK32": {
"VkFormatProperties": {
"linearTilingFeatures": [
"VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT"
],
"optimalTilingFeatures": [
"VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT"
],
"bufferFeatures": [
"VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT"
]