From e561070e1a6d7296d36e3158673d2e9e17650969 Mon Sep 17 00:00:00 2001 From: Rohan Garg Date: Mon, 21 Jul 2025 16:45:52 +0200 Subject: [PATCH] intel/compiler: use the WA framework when emitting WA 14014595444 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixes: d276ad4 "intel/compiler: implement Wa_14014595444 for DG2" Signed-off-by: Rohan Garg Reviewed-by: Tapani Pälli Part-of: (cherry picked from commit c978394e000a9aa5e5fc6bbd7e82209a4ccaae68) --- .pick_status.json | 2 +- src/intel/compiler/brw_lower_logical_sends.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 4cc7f5285eb..d1d6d590161 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -6804,7 +6804,7 @@ "description": "intel/compiler: use the WA framework when emitting WA 14014595444", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "d276ad45207356abeed1fd920714443b553ed1a2", "notes": null diff --git a/src/intel/compiler/brw_lower_logical_sends.cpp b/src/intel/compiler/brw_lower_logical_sends.cpp index ab8e4aaa424..31b27d9e359 100644 --- a/src/intel/compiler/brw_lower_logical_sends.cpp +++ b/src/intel/compiler/brw_lower_logical_sends.cpp @@ -1113,8 +1113,8 @@ lower_sampler_logical_send(const brw_builder &bld, brw_inst *inst, bld.MOV(sources[length++], min_lod); /* Wa_14014595444: Populate MLOD as parameter 5 (twice). */ - if (devinfo->verx10 == 125 && op == FS_OPCODE_TXB_LOGICAL && - shadow_c.file == BAD_FILE) + if (intel_needs_workaround(devinfo, 14014595444) && + op == FS_OPCODE_TXB_LOGICAL && shadow_c.file == BAD_FILE) bld.MOV(sources[length++], min_lod); }