radv: CSE ray_launch_{size|id}

Stats for Q2RTX
Totals from 7 (0.01% of 134913) affected shaders: (GFX10.3)

VGPRs: 736 -> 704 (-4.35%)
CodeSize: 204424 -> 204400 (-0.01%); split: -0.03%, +0.02%
MaxWaves: 67 -> 69 (+2.99%)
Instrs: 37540 -> 37549 (+0.02%); split: -0.02%, +0.04%
Latency: 973556 -> 973267 (-0.03%)
InvThroughput: 209068 -> 200902 (-3.91%)
VClause: 920 -> 921 (+0.11%); split: -0.11%, +0.22%
SClause: 1045 -> 1043 (-0.19%)
Copies: 4853 -> 4865 (+0.25%); split: -0.08%, +0.33%
Branches: 1571 -> 1578 (+0.45%)
PreSGPRs: 421 -> 407 (-3.33%)
PreVGPRs: 638 -> 632 (-0.94%)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21156>
This commit is contained in:
Daniel Schürmann 2023-01-31 14:46:57 +01:00 committed by Marge Bot
parent 8ebb34ee57
commit e5600d5257

View file

@ -98,6 +98,9 @@ struct rt_variables {
/* global address of the SBT entry used for the shader */
nir_variable *shader_record_ptr;
nir_variable *launch_size;
nir_variable *launch_id;
/* trace_ray arguments */
nir_variable *accel_struct;
nir_variable *flags;
@ -157,6 +160,10 @@ create_rt_variables(nir_shader *shader, const VkRayTracingPipelineCreateInfoKHR
vars.shader_record_ptr =
nir_variable_create(shader, nir_var_shader_temp, glsl_uint64_t_type(), "shader_record_ptr");
const struct glsl_type *uvec3_type = glsl_vector_type(GLSL_TYPE_UINT, 3);
vars.launch_size = nir_variable_create(shader, nir_var_shader_temp, uvec3_type, "launch_size");
vars.launch_id = nir_variable_create(shader, nir_var_shader_temp, uvec3_type, "launch_id");
const struct glsl_type *vec3_type = glsl_vector_type(GLSL_TYPE_FLOAT, 3);
vars.accel_struct =
nir_variable_create(shader, nir_var_shader_temp, glsl_uint64_t_type(), "accel_struct");
@ -204,6 +211,8 @@ map_rt_variables(struct hash_table *var_remap, struct rt_variables *src,
_mesa_hash_table_insert(var_remap, src->arg, dst->arg);
_mesa_hash_table_insert(var_remap, src->stack_ptr, dst->stack_ptr);
_mesa_hash_table_insert(var_remap, src->shader_record_ptr, dst->shader_record_ptr);
_mesa_hash_table_insert(var_remap, src->launch_size, dst->launch_size);
_mesa_hash_table_insert(var_remap, src->launch_id, dst->launch_id);
_mesa_hash_table_insert(var_remap, src->accel_struct, dst->accel_struct);
_mesa_hash_table_insert(var_remap, src->flags, dst->flags);
@ -422,23 +431,11 @@ lower_rt_instructions(nir_shader *shader, struct rt_variables *vars, unsigned ca
break;
}
case nir_intrinsic_load_ray_launch_id: {
ret = nir_load_global_invocation_id(&b_shader, 32);
ret = nir_load_var(&b_shader, vars->launch_id);
break;
}
case nir_intrinsic_load_ray_launch_size: {
nir_ssa_def *launch_size_addr = nir_load_ray_launch_size_addr_amd(&b_shader);
nir_ssa_def *xy = nir_build_load_smem_amd(&b_shader, 2, launch_size_addr,
nir_imm_int(&b_shader, 0));
nir_ssa_def *z = nir_build_load_smem_amd(&b_shader, 1, launch_size_addr,
nir_imm_int(&b_shader, 8));
nir_ssa_def *xyz[3] = {
nir_channel(&b_shader, xy, 0),
nir_channel(&b_shader, xy, 1),
z,
};
ret = nir_vec(&b_shader, xyz, 3);
ret = nir_load_var(&b_shader, vars->launch_size);
break;
}
case nir_intrinsic_load_ray_t_min: {
@ -1328,6 +1325,8 @@ build_traversal_shader(struct radv_device *device,
nir_store_var(&b, vars.tmax, nir_load_ray_t_max(&b), 0x1);
nir_store_var(&b, vars.arg, nir_load_rt_arg_scratch_offset_amd(&b), 0x1);
nir_store_var(&b, vars.stack_ptr, nir_imm_int(&b, 0), 0x1);
nir_store_var(&b, vars.launch_size, nir_load_ray_launch_size(&b), 0x7);
nir_store_var(&b, vars.launch_id, nir_load_ray_launch_id(&b), 0x7);
struct rt_traversal_vars trav_vars = init_traversal_vars(&b);
@ -1590,6 +1589,17 @@ create_rt_shader(struct radv_device *device, const VkRayTracingPipelineCreateInf
else
nir_store_var(&b, vars.stack_ptr, nir_imm_int(&b, 0), 0x1);
nir_store_var(&b, vars.launch_id, nir_load_global_invocation_id(&b, 32), 0x7);
nir_ssa_def *launch_size_addr = nir_load_ray_launch_size_addr_amd(&b);
nir_ssa_def *xy = nir_build_load_smem_amd(&b, 2, launch_size_addr, nir_imm_int(&b, 0));
nir_ssa_def *z = nir_build_load_smem_amd(&b, 1, launch_size_addr, nir_imm_int(&b, 8));
nir_ssa_def *xyz[3] = {
nir_channel(&b, xy, 0),
nir_channel(&b, xy, 1),
z,
};
nir_store_var(&b, vars.launch_size, nir_vec(&b, xyz, 3), 0x7);
nir_variable *hit_attribs[RADV_MAX_HIT_ATTRIB_SIZE / sizeof(uint32_t)];
for (uint32_t i = 0; i < ARRAY_SIZE(hit_attribs); i++)
hit_attribs[i] = nir_local_variable_create(nir_shader_get_entrypoint(b.shader),