fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 17:30:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

hasvk: Disable non-zero fast clears for 8xMSAA images

Browse source 
Using texelFetch to read samples from an 8xMSAA fast cleared image on
Haswell can read transparent black pixels around triangles from where
there should be none. This issue isn't present when using sample
shading, resolving the image using vkCmdResolveImage or in a copy the
image. The easiest way to fix this is by just disabling non-zero fast
clears for 8xMSAA images.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7587

Cc: mesa-stable
Reviewed-by: Filip Gawin <filip@gawin.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21444>
This commit is contained in:
Väinö Mäkelä 2023-02-21 14:39:21 +02:00 • committed by Marge Bot
parent dc01f03d1b
commit e509afacf3
1 changed files with 7 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/intel/vulkan_hasvk/anv_image.c
View file

@ -375,6 +375,13 @@ can_fast_clear_with_non_zero_color(const struct intel_device_info *devinfo,
uint32_t plane,
const VkImageFormatListCreateInfo *fmt_list)
{
/* Triangles rendered on non-zero fast cleared images with 8xMSAA can get
* black pixels around them on Haswell.
*/
if (devinfo->ver == 7 && image->vk.samples == 8) {
return false;
}
/* If we don't have an AUX surface where fast clears apply, we can return
* early.
*/