fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-28 23:20:08 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panvk: check for texture-compression support

Browse source 
We currently just assume that textureCompressionETC2 and
textureCompressionASTC_LDR are always supported. And while that's true
for all the G52s, G610s abd G310s we've seen out in the wild, it's not
guaranteed to be true. An SoC vendor might disable support for one of
these formats.

So let's check properly, just for good measure.

Fixes: d970fe2e9d ("panfrost: Add a Vulkan driver for Midgard/Bifrost GPUs")
Reviewed-by: Eric R. Smith <eric.smith@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34206>
(cherry picked from commit e4786cf971)
This commit is contained in:
Erik Faye-Lund 2025-03-31 17:44:44 +02:00 • committed by Eric Engestrom
parent d34e17a9ce
commit e4f5908a57
2 changed files with 29 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -174,7 +174,7 @@
"description": "panvk: check for texture-compression support",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "d970fe2e9d6a8e9997a0ce212146d62013b3b455",
"notes": null

30
src/panfrost/vulkan/panvk_physical_device.c
View file

@ -253,6 +253,32 @@ get_device_extensions(const struct panvk_physical_device *device,
};
}
static bool
has_compressed_formats(const struct panvk_physical_device *physical_device,
const uint32_t required_formats)
{
uint32_t supported_compr_fmts =
panfrost_query_compressed_formats(&physical_device->kmod.props);
return (supported_compr_fmts & required_formats) == required_formats;
}
static bool
has_texture_compression_etc2(const struct panvk_physical_device *physical_device)
{
return has_compressed_formats(physical_device,
BITFIELD_BIT(MALI_ETC2_RGB8) |
BITFIELD_BIT(MALI_ETC2_RGB8A1) | BITFIELD_BIT(MALI_ETC2_RGBA8) |
BITFIELD_BIT(MALI_ETC2_R11_UNORM) | BITFIELD_BIT(MALI_ETC2_R11_SNORM) |
BITFIELD_BIT(MALI_ETC2_RG11_UNORM) | BITFIELD_BIT(MALI_ETC2_RG11_SNORM));
}
static bool
has_texture_compression_astc_ldr(const struct panvk_physical_device *physical_device)
{
return has_compressed_formats(physical_device, BITFIELD_BIT(MALI_ASTC_2D_LDR));
}
static void
get_features(const struct panvk_physical_device *device,
struct vk_features *features)
@ -273,8 +299,8 @@ get_features(const struct panvk_physical_device *device,
.largePoints = true,
.occlusionQueryPrecise = true,
.samplerAnisotropy = true,
.textureCompressionETC2 = true,
.textureCompressionASTC_LDR = true,
.textureCompressionETC2 = has_texture_compression_etc2(device),
.textureCompressionASTC_LDR = has_texture_compression_astc_ldr(device),
.fragmentStoresAndAtomics = arch >= 10,
.shaderUniformBufferArrayDynamicIndexing = true,
.shaderSampledImageArrayDynamicIndexing = true,