From e488b46419b17524aeac454f2312cc5493187a05 Mon Sep 17 00:00:00 2001 From: Ian Romanick Date: Fri, 31 Mar 2023 18:13:57 -0700 Subject: [PATCH] intel/fs: Don't continue fixed point iteration just because liveout changes Unless the change in liveout also causes livein to change, updates to liveout cannot have any global effect. Changes to livein already flag additional interation. I had additional changes in this area that didn't pan out. While working on those change, I was a little confused about this bit of code. It's unnecessary, so it's better to delete it. Reviewed-by: Kenneth Graunke Part-of: --- src/intel/compiler/brw_fs_live_variables.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/intel/compiler/brw_fs_live_variables.cpp b/src/intel/compiler/brw_fs_live_variables.cpp index f56692214da..62037d75bb8 100644 --- a/src/intel/compiler/brw_fs_live_variables.cpp +++ b/src/intel/compiler/brw_fs_live_variables.cpp @@ -192,17 +192,13 @@ fs_live_variables::compute_live_variables() BITSET_WORD new_liveout = (child_bd->livein[i] & ~bd->liveout[i]); new_liveout &= bd->defout[i]; /* Screen off uses with no reaching def */ - if (new_liveout) { + if (new_liveout) bd->liveout[i] |= new_liveout; - cont = true; - } } BITSET_WORD new_liveout = (child_bd->flag_livein[0] & ~bd->flag_liveout[0]); - if (new_liveout) { + if (new_liveout) bd->flag_liveout[0] |= new_liveout; - cont = true; - } } /* Update livein */