diff --git a/.pick_status.json b/.pick_status.json index f477ac5db7d..f15d62d2560 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -247,7 +247,7 @@ "description": "aco: Mark VCC clobbered for iadd8 and iadd16 reductions on GFX6-7.", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": null }, diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp index b473f0dc62c..9364998462b 100644 --- a/src/amd/compiler/aco_instruction_selection.cpp +++ b/src/amd/compiler/aco_instruction_selection.cpp @@ -7506,6 +7506,8 @@ Temp emit_reduction_instr(isel_context *ctx, aco_opcode aco_op, ReduceOp op, bool clobber_vcc = false; if ((op == iadd32 || op == imul64) && ctx->program->chip_class < GFX9) clobber_vcc = true; + if ((op == iadd8 || op == iadd16) && ctx->program->chip_class < GFX8) + clobber_vcc = true; if (op == iadd64 || op == umin64 || op == umax64 || op == imin64 || op == imax64) clobber_vcc = true;