From e42b0c68f448fa0a57591ab6ef2aa9e2017551a5 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Sat, 29 Jan 2022 10:16:21 -0500 Subject: [PATCH] panfrost: Don't pack blend constants with blend shaders It's probably harmless, but it is logically meaningless. The DDK doesn't do it, I don't see a reason for us to, either. In theory this should be a small overhead win. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/gallium/drivers/panfrost/pan_cmdstream.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c index ab165d18d77..ac6356fd126 100644 --- a/src/gallium/drivers/panfrost/pan_cmdstream.c +++ b/src/gallium/drivers/panfrost/pan_cmdstream.c @@ -304,7 +304,8 @@ panfrost_emit_blend(struct panfrost_batch *batch, void *rts, mali_ptr *blend_sha cfg.round_to_fb_precision = !dithered; cfg.alpha_to_one = ctx->blend->base.alpha_to_one; #if PAN_ARCH >= 6 - cfg.constant = pack_blend_constant(format, cons); + if (!blend_shaders[i]) + cfg.constant = pack_blend_constant(format, cons); #else cfg.blend_shader = (blend_shaders[i] != 0);