fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-06-10 01:18:18 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

jay: Generalize EXTRACT_LAYER to take an arbitrary mask

Browse source 
This will let us use it for the other per-pair-of-subspan fields too.

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41872>
This commit is contained in:
Kenneth Graunke 2026-05-28 11:39:12 -07:00 • committed by Marge Bot
parent 2c9df4caad
commit e3d7d4a77d
4 changed files with 12 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/intel/compiler/jay/jay_from_nir.c
View file

@ -1501,8 +1501,8 @@ jay_emit_intrinsic(struct nir_to_jay_state *nj, nir_intrinsic_instr *intr)
break;
case nir_intrinsic_load_layer_id:
jay_EXTRACT_LAYER(b, dst, jay_extract(nj->payload.u0, 9),
payload_u1(nj, 9, 1));
jay_EXTRACT_SUBSPAN_INFO(b, dst, jay_extract(nj->payload.u0, 9),
payload_u1(nj, 9, 1), 0x7ff);
break;
case nir_intrinsic_load_front_face: {

2
src/intel/compiler/jay/jay_opcodes.py
View file

@ -174,7 +174,7 @@ op('and_u32_u16', 2, 'u32')
# 2x16-bit offset within each quad, giving 2x16-bit per-lane coordinates.
op('expand_quad', 2, 'u32')
op('offset_packed_pixel_coords', 1, 'u32')
op('extract_layer', 2, 'u32')
op('extract_subspan_info', 2, 'u32', Props.CMOD, ['uint16_t mask'])
# Phi function representations
#

2
src/intel/compiler/jay/jay_simd_width.c
View file

@ -18,7 +18,7 @@ max_simd_width(const jay_shader *shader, const jay_inst *I)
/* These special instructions need to be split for various reasons. */
if (I->op == JAY_OPCODE_EXPAND_QUAD ||
I->op == JAY_OPCODE_EXTRACT_LAYER ||
I->op == JAY_OPCODE_EXTRACT_SUBSPAN_INFO ||
I->op == JAY_OPCODE_EXTRACT_BYTE_PER_8LANES ||
I->op == JAY_OPCODE_OFFSET_PACKED_PIXEL_COORDS ||
I->op == JAY_OPCODE_DESWIZZLE_ODD ||

14
src/intel/compiler/jay/jay_to_binary.c
View file

@ -260,7 +260,7 @@ static const struct {
OP(ENDIF, ENDIF, 0),
OP(EXPAND_QUAD, MOV, 2),
OP(EXTRACT_BYTE_PER_8LANES, MOV, 2),
OP(EXTRACT_LAYER, AND, 2),
OP(EXTRACT_SUBSPAN_INFO, AND, 2),
OP(FBH, FBH, 1),
OP(FBL, FBL, 1),
OP(FRC, FRC, 1),
@ -503,14 +503,16 @@ emit(struct jay_codegen *jc,
break;
}
/* Gfx20+ has separate Render Target Array indices for each pair of subspans
* in order to support multiple polygons, so we need to use a <1;8,0> region
* in order to select the word for each channel.
/* On Gfx20+, the viewport index, render target array index, and facing
* fields come together in consecutive words for each pair of subspans.
* We use a <1;8,0>W region so that each pair of 4-lane subspans reads
* the right value, and split to SIMD16 since the high subspans come
* in a separate register.
*/
case JAY_OPCODE_EXTRACT_LAYER:
case JAY_OPCODE_EXTRACT_SUBSPAN_INFO:
gen->src[0] =
gen_restride(gen_retype(gen->src[simd_offs], GEN_TYPE_UW), 1, 8, 0);
gen->src[1] = gen_imm_uw(0x7ff);
gen->src[1] = gen_imm_uw(jay_extract_subspan_info_mask(I));
break;
case JAY_OPCODE_EXPAND_QUAD: