fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-15 22:58:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/bi: Use LOD_MODE_EXPLICIT for the 2nd half of textureGrad() on Bifrost

Browse source 
textureGrad() has to be split into two halves on Mali: Computing the
gradient/LOD and doing the actual texture operation.  On Valhal, we do
this with LOD_MODE_GRDESC but on Bifrost, we use LOD_MOD_EXPLICIT.  When
converting to NIR, I missed this.

Fixes: 05a066c921 ("pan/nir: Add bifrost support to pan_nir_lower_tex()")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41513>
This commit is contained in:
Faith Ekstrand 2026-05-12 10:20:34 -04:00 • committed by Marge Bot
parent 804ff19a5a
commit e3d5d13d6d
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/panfrost/compiler/pan_nir_lower_tex.c
View file

@ -565,12 +565,11 @@ bi_lower_tex(nir_builder *b, nir_tex_instr *tex, uint64_t gpu_id)
desc.lod_or_fetch = BIFROST_LOD_MODE_BIAS;
sr[BI_TEX_SR_LOD] = build_lod_bias_clamp(b, srcs.bias, srcs.min_lod);
} else if (srcs.ddx || srcs.ddy) {
desc.lod_or_fetch = BIFROST_LOD_MODE_GRDESC;
desc.lod_or_fetch = BIFROST_LOD_MODE_EXPLICIT;
nir_def *grdesc = build_bi_gradient_desc(b, srcs.tex_h, srcs.samp_h,
tex->sampler_dim,
srcs.ddx, srcs.ddy);
sr[BI_TEX_SR_GRDESC0] = nir_channel(b, grdesc, 0);
sr[BI_TEX_SR_GRDESC1] = nir_channel(b, grdesc, 1);
sr[BI_TEX_SR_LOD] = nir_channel(b, grdesc, 0);
} else {
desc.lod_or_fetch = BIFROST_LOD_MODE_COMPUTE;
}