fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 07:28:11 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

panvk/csf: fix alpha-to-coverage

Browse source 
The equivalent bit is set correctly on JM, but was missed for CSF. There
shouldn't need to be any shader changes, the alpha-to-coverage flag in
FAU_ATEST_PARAM is set automatically from the bit in DcdFlags0.

Fixes dEQP-VK.pipeline.*.multisample.alpha_to_coverage*

Fixes: 447075eeee ("panfrost: Add support for the CSF job frontend")
Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Reviewed-by: Mary Guillemard <mary.guillemard@collabora.com>
(cherry picked from commit 3f90d8dfd2)

Conflicts:
	src/panfrost/ci/panfrost-g610-fails.txt
	src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32852>
This commit is contained in:
Benjamin Lee 2024-12-17 19:23:45 -08:00 • committed by Dylan Baker
parent 361316b1ea
commit e3a186a3ce
2 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -3114,7 +3114,7 @@
"description": "panvk/csf: fix alpha-to-coverage",
"nominated": true,
"nomination_type": 2,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "447075eeeef8a9fd91f42ae869fd2e0246513356",
"notes": null

1
src/panfrost/vulkan/csf/panvk_vX_cmd_draw.c
View file

@ -1352,6 +1352,7 @@ prepare_dcd(struct panvk_cmd_buffer *cmdbuf)
cfg.cull_back_face = (rs->cull_mode & VK_CULL_MODE_BACK_BIT) != 0;
cfg.multisample_enable = dyns->ms.rasterization_samples > 1;
cfg.alpha_to_coverage = alpha_to_coverage;
}
cs_update_vt_ctx(b)