From e33bbe7ee7c601a362ccf2f6fd3b996993adec74 Mon Sep 17 00:00:00 2001 From: "You, Min-Hsuan" Date: Sat, 8 Nov 2025 12:51:22 +0800 Subject: [PATCH] amd/vpelib: refactor minor change Make dscl_set_scaler_position be a function pointer Acked-by: Chuanyu Tseng Singed-off-by: Min-Hsuan You Part-of: --- src/amd/vpelib/src/chip/vpe10/inc/vpe10_dpp.h | 2 ++ src/amd/vpelib/src/chip/vpe10/vpe10_dpp.c | 1 + src/amd/vpelib/src/chip/vpe10/vpe10_dpp_dscl.c | 4 ++-- src/amd/vpelib/src/core/inc/dpp.h | 2 ++ 4 files changed, 7 insertions(+), 2 deletions(-) diff --git a/src/amd/vpelib/src/chip/vpe10/inc/vpe10_dpp.h b/src/amd/vpelib/src/chip/vpe10/inc/vpe10_dpp.h index 45999136cbf..47e2cb9009f 100644 --- a/src/amd/vpelib/src/chip/vpe10/inc/vpe10_dpp.h +++ b/src/amd/vpelib/src/chip/vpe10/inc/vpe10_dpp.h @@ -893,6 +893,8 @@ void vpe10_dpp_set_hdr_multiplier(struct dpp *dpp, uint32_t multiplier); /*Program Scaler*/ void vpe10_dpp_set_segment_scaler(struct dpp *dpp, const struct scaler_data *scl_data); +void vpe10_dpp_dscl_set_scaler_position(struct dpp *dpp, const struct scaler_data *scl_data); + void vpe10_dpp_set_frame_scaler(struct dpp *dpp, const struct scaler_data *scl_data); /*Scalar helper functions*/ diff --git a/src/amd/vpelib/src/chip/vpe10/vpe10_dpp.c b/src/amd/vpelib/src/chip/vpe10/vpe10_dpp.c index d57504b9860..fe54218b0d7 100644 --- a/src/amd/vpelib/src/chip/vpe10/vpe10_dpp.c +++ b/src/amd/vpelib/src/chip/vpe10/vpe10_dpp.c @@ -54,6 +54,7 @@ static struct dpp_funcs vpe10_dpp_funcs = { .get_optimal_number_of_taps = vpe10_dpp_get_optimal_number_of_taps, .dscl_calc_lb_num_partitions = vpe10_dscl_calc_lb_num_partitions, .set_segment_scaler = vpe10_dpp_set_segment_scaler, + .dscl_set_scaler_position = vpe10_dpp_dscl_set_scaler_position, .set_frame_scaler = vpe10_dpp_set_frame_scaler, .get_line_buffer_size = vpe10_get_line_buffer_size, .validate_number_of_taps = vpe10_dpp_validate_number_of_taps, diff --git a/src/amd/vpelib/src/chip/vpe10/vpe10_dpp_dscl.c b/src/amd/vpelib/src/chip/vpe10/vpe10_dpp_dscl.c index e0957f0e732..39b24c73a17 100644 --- a/src/amd/vpelib/src/chip/vpe10/vpe10_dpp_dscl.c +++ b/src/amd/vpelib/src/chip/vpe10/vpe10_dpp_dscl.c @@ -242,7 +242,7 @@ void vpe10_dpp_dscl_set_scale_ratio(struct dpp *dpp, const struct scaler_data *d vpe_fixpt_u3d19(data->ratios.vert_c) << 5); } -static void dpp1_dscl_set_scaler_position(struct dpp *dpp, const struct scaler_data *data) +void vpe10_dpp_dscl_set_scaler_position(struct dpp *dpp, const struct scaler_data *data) { uint32_t init_frac = 0; uint32_t init_int = 0; @@ -312,7 +312,7 @@ void vpe10_dpp_set_segment_scaler(struct dpp *dpp, const struct scaler_data *scl if (dscl_mode == DSCL_MODE_DSCL_BYPASS) return; - dpp1_dscl_set_scaler_position(dpp, scl_data); + dpp->funcs->dscl_set_scaler_position(dpp, scl_data); } void vpe10_dpp_set_frame_scaler(struct dpp *dpp, const struct scaler_data *scl_data) diff --git a/src/amd/vpelib/src/core/inc/dpp.h b/src/amd/vpelib/src/core/inc/dpp.h index a69dbf52ef1..71314f565a8 100644 --- a/src/amd/vpelib/src/core/inc/dpp.h +++ b/src/amd/vpelib/src/core/inc/dpp.h @@ -106,6 +106,8 @@ struct dpp_funcs { /** scaler */ void (*set_segment_scaler)(struct dpp *dpp, const struct scaler_data *scl_data); + void (*dscl_set_scaler_position)(struct dpp *dpp, const struct scaler_data *scl_data); + void (*set_frame_scaler)(struct dpp *dpp, const struct scaler_data *scl_data); uint32_t (*get_line_buffer_size)(void);