virtio: virtgpu_kumquat: clippy fixes

Run clippy and fix the warnings.

Reviewed-by: David Gilhooley <djgilhooley.gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/37530>
This commit is contained in:
Gurchetan Singh 2025-09-23 08:11:57 -07:00 committed by Marge Bot
parent ce1d0ae108
commit e2b0dee91f

View file

@ -119,7 +119,7 @@ impl VirtGpuKumquat {
_ => return Err(MesaError::Unsupported), _ => return Err(MesaError::Unsupported),
}; };
capset_mask = 1u64 << resp_capset_info.capset_id | capset_mask; capset_mask |= 1u64 << resp_capset_info.capset_id;
capsets.insert(resp_capset_info.capset_id, capset); capsets.insert(resp_capset_info.capset_id, capset);
} }
@ -134,7 +134,7 @@ impl VirtGpuKumquat {
} }
pub fn allocate_id(&mut self) -> u32 { pub fn allocate_id(&mut self) -> u32 {
self.id_allocator = self.id_allocator + 1; self.id_allocator += 1;
self.id_allocator self.id_allocator
} }
@ -233,7 +233,7 @@ impl VirtGpuKumquat {
create_blob: &mut VirtGpuResourceCreateBlob, create_blob: &mut VirtGpuResourceCreateBlob,
blob_cmd: &[u8], blob_cmd: &[u8],
) -> MesaResult<()> { ) -> MesaResult<()> {
if blob_cmd.len() != 0 { if !blob_cmd.is_empty() {
let submit_command = kumquat_gpu_protocol_cmd_submit { let submit_command = kumquat_gpu_protocol_cmd_submit {
hdr: kumquat_gpu_protocol_ctrl_hdr { hdr: kumquat_gpu_protocol_ctrl_hdr {
type_: KUMQUAT_GPU_PROTOCOL_SUBMIT_3D, type_: KUMQUAT_GPU_PROTOCOL_SUBMIT_3D,
@ -439,7 +439,7 @@ impl VirtGpuKumquat {
} }
let need_fence = let need_fence =
bo_handles.len() != 0 || (flags & VIRTGPU_KUMQUAT_EXECBUF_FENCE_FD_OUT) != 0; !bo_handles.is_empty() || (flags & VIRTGPU_KUMQUAT_EXECBUF_FENCE_FD_OUT) != 0;
let actual_fence = (flags & VIRTGPU_KUMQUAT_EXECBUF_SHAREABLE_OUT) != 0 let actual_fence = (flags & VIRTGPU_KUMQUAT_EXECBUF_SHAREABLE_OUT) != 0
&& (flags & VIRTGPU_KUMQUAT_EXECBUF_FENCE_FD_OUT) != 0; && (flags & VIRTGPU_KUMQUAT_EXECBUF_FENCE_FD_OUT) != 0;
@ -545,10 +545,10 @@ impl VirtGpuKumquat {
)?; )?;
let mesa_mapping = mapping.as_mesa_mapping(); let mesa_mapping = mapping.as_mesa_mapping();
let mut slice: &mut [u8] = unsafe { let slice: &mut [u8] = unsafe {
from_raw_parts_mut(mesa_mapping.ptr as *mut u8, VIRTGPU_KUMQUAT_PAGE_SIZE) from_raw_parts_mut(mesa_mapping.ptr as *mut u8, VIRTGPU_KUMQUAT_PAGE_SIZE)
}; };
let mut writer = Writer::new(&mut slice); let mut writer = Writer::new(slice);
writer.write_obj(resource.resource_id)?; writer.write_obj(resource.resource_id)?;
// Opaque to users of this API, shared memory internally // Opaque to users of this API, shared memory internally
@ -578,10 +578,10 @@ impl VirtGpuKumquat {
let mesa_mapping = mapping.as_mesa_mapping(); let mesa_mapping = mapping.as_mesa_mapping();
let mut slice: &mut [u8] = let slice: &mut [u8] =
unsafe { from_raw_parts_mut(mesa_mapping.ptr as *mut u8, VIRTGPU_KUMQUAT_PAGE_SIZE) }; unsafe { from_raw_parts_mut(mesa_mapping.ptr as *mut u8, VIRTGPU_KUMQUAT_PAGE_SIZE) };
let mut reader = Reader::new(&mut slice); let mut reader = Reader::new(slice);
*resource_handle = reader.read_obj()?; *resource_handle = reader.read_obj()?;
let attach_resource = kumquat_gpu_protocol_ctx_resource { let attach_resource = kumquat_gpu_protocol_ctx_resource {