fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 11:38:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

anv: Add clear_supported to anv_layout_to_aux_state

Browse source 
This will be used for an MCS workaround.

Cc: mesa-stable
Reviewed-by: Sagar Ghuge <sagar.ghuge@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8755>
(cherry picked from commit 608c131638)
This commit is contained in:
Nanley Chery 2021-01-26 15:42:28 -08:00 • committed by Eric Engestrom
parent 443854ecec
commit e266136b38
2 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -103,7 +103,7 @@
"description": "anv: Add clear_supported to anv_layout_to_aux_state",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": null
},

19
src/intel/vulkan/anv_image.c
View file

@ -2161,6 +2161,7 @@ anv_layout_to_aux_state(const struct gen_device_info * const devinfo,
vk_image_layout_to_usage_flags(layout, aspect) & image_aspect_usage;
bool aux_supported = true;
bool clear_supported = isl_aux_usage_has_fast_clears(aux_usage);
if ((usage & VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT) && !read_only) {
/* This image could be used as both an input attachment and a render
@ -2172,24 +2173,31 @@ anv_layout_to_aux_state(const struct gen_device_info * const devinfo,
*
* TODO: Should we be disabling this in more cases?
*/
if (aspect == VK_IMAGE_ASPECT_DEPTH_BIT)
if (aspect == VK_IMAGE_ASPECT_DEPTH_BIT) {
aux_supported = false;
clear_supported = false;
}
}
if (usage & VK_IMAGE_USAGE_STORAGE_BIT)
if (usage & VK_IMAGE_USAGE_STORAGE_BIT) {
aux_supported = false;
clear_supported = false;
}
if (usage & (VK_IMAGE_USAGE_TRANSFER_SRC_BIT |
VK_IMAGE_USAGE_SAMPLED_BIT |
VK_IMAGE_USAGE_INPUT_ATTACHMENT_BIT)) {
switch (aux_usage) {
case ISL_AUX_USAGE_HIZ:
if (!anv_can_sample_with_hiz(devinfo, image))
if (!anv_can_sample_with_hiz(devinfo, image)) {
aux_supported = false;
clear_supported = false;
}
break;
case ISL_AUX_USAGE_HIZ_CCS:
aux_supported = false;
clear_supported = false;
break;
case ISL_AUX_USAGE_HIZ_CCS_WT:
@ -2197,6 +2205,7 @@ anv_layout_to_aux_state(const struct gen_device_info * const devinfo,
case ISL_AUX_USAGE_CCS_D:
aux_supported = false;
clear_supported = false;
break;
case ISL_AUX_USAGE_CCS_E:
@ -2214,6 +2223,7 @@ anv_layout_to_aux_state(const struct gen_device_info * const devinfo,
case ISL_AUX_USAGE_HIZ_CCS:
case ISL_AUX_USAGE_HIZ_CCS_WT:
if (aux_supported) {
assert(clear_supported);
return ISL_AUX_STATE_COMPRESSED_CLEAR;
} else if (read_only) {
return ISL_AUX_STATE_RESOLVED;
@ -2225,6 +2235,7 @@ anv_layout_to_aux_state(const struct gen_device_info * const devinfo,
/* We only support clear in exactly one state */
if (layout == VK_IMAGE_LAYOUT_COLOR_ATTACHMENT_OPTIMAL) {
assert(aux_supported);
assert(clear_supported);
return ISL_AUX_STATE_PARTIAL_CLEAR;
} else {
return ISL_AUX_STATE_PASS_THROUGH;
@ -2233,6 +2244,7 @@ anv_layout_to_aux_state(const struct gen_device_info * const devinfo,
case ISL_AUX_USAGE_CCS_E:
case ISL_AUX_USAGE_MCS:
if (aux_supported) {
assert(clear_supported);
return ISL_AUX_STATE_COMPRESSED_CLEAR;
} else {
return ISL_AUX_STATE_PASS_THROUGH;
@ -2240,6 +2252,7 @@ anv_layout_to_aux_state(const struct gen_device_info * const devinfo,
case ISL_AUX_USAGE_STC_CCS:
assert(aux_supported);
assert(!clear_supported);
return ISL_AUX_STATE_COMPRESSED_NO_CLEAR;
default: