fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-01 05:58:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

pan/decode: Fix helper invocations when tracing

Browse source 
midgard1.flags_lo was being changed when tracing, causing helper
invocations to be disabled.

This was found by using mprotect to make BOs read only in
pandecode_fetch_gpu_mem.

Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5573>
This commit is contained in:
Icecream95 2020-06-20 17:54:19 +12:00 • committed by Marge Bot
parent 97318994bc
commit e219f04592
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/panfrost/pandecode/decode.c
View file

@ -2616,7 +2616,6 @@ pandecode_vertex_tiler_postfix_pre(
pandecode_log_cont(",\n");
} else {
bool helpers = s->midgard1.flags_lo & MALI_HELPER_INVOCATIONS;
s->midgard1.flags_lo &= ~MALI_HELPER_INVOCATIONS;
if (helpers != info.helper_invocations) {
pandecode_msg("XXX: expected helpers %u but got %u\n",
@ -2624,7 +2623,8 @@ pandecode_vertex_tiler_postfix_pre(
}
pandecode_log(".midgard1.flags_lo = ");
pandecode_log_decoded_flags(shader_midgard1_flag_lo_info, s->midgard1.flags_lo);
pandecode_log_decoded_flags(shader_midgard1_flag_lo_info,
s->midgard1.flags_lo & ~MALI_HELPER_INVOCATIONS);
pandecode_log_cont(",\n");
pandecode_log(".midgard1.flags_hi = ");