fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-03 11:30:21 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

i965: Fix math instruction hstride assertions on Broadwell.

Browse source 
In the final revision of my gen8_generator patch, I updated the MATH
instruction's assertion from (dst.hstride == 1) to check that source and
destination hstride matched.  Unfortunately, I didn't test this enough,
and many Piglit tests fail this test.

The documentation indicates that "scalar source is also supported",
which we believe means <0,1,0> access mode (hstride == 0).  If hstride
is non-zero, then it must match the destination register.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Matt Turner <mattst88@gmail.com>
This commit is contained in:
Kenneth Graunke 2014-01-30 17:50:02 -08:00
parent d8878055f5
commit e1cdafe6f7
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/mesa/drivers/dri/i965/gen8_generator.cpp
View file

@ -299,7 +299,7 @@ gen8_generator::math(unsigned math_function,
{
gen8_instruction *inst = next_inst(BRW_OPCODE_MATH);
assert(dst.hstride == src0.hstride);
assert(src0.hstride == 0 || src0.hstride == dst.hstride);
gen8_set_math_function(inst, math_function);
gen8_set_dst(brw, inst, dst);