fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 11:18:08 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ac/nir: fix a typo in ac_are_tessfactors_def_in_all_invocs

Browse source 
I think it only made the pass return false if there was a barrier

Fixes: 2832bc972b - ac/nir_to_llvm: add ac_are_tessfactors_def_in_all_invocs()

Reviewed-by: Timothy Arceri <tarceri@itsqueeze.com>
Acked-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7623>
(cherry picked from commit 9659384744)
This commit is contained in:
Marek Olšák 2020-11-13 23:13:45 -05:00 • committed by Dylan Baker
parent 64b117c49f
commit e0cf53b127
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -3595,7 +3595,7 @@
"description": "ac/nir: fix a typo in ac_are_tessfactors_def_in_all_invocs",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"master_sha": null,
"because_sha": "2832bc972bfb512b314a3180a1258be984807760"
},

2
src/amd/llvm/ac_nir_to_llvm.c
View file

@ -5132,7 +5132,7 @@ static void scan_tess_ctrl(nir_cf_node *cf_node, unsigned *upper_block_tf_writem
* such segment that writes tess factor channels should write the same
* channels in all codepaths within that segment.
*/
if (upper_block_tf_writemask || cond_block_tf_writemask) {
if (*upper_block_tf_writemask || *cond_block_tf_writemask) {
/* Accumulate the result: */
*tessfactors_are_def_in_all_invocs &=
!(*cond_block_tf_writemask & ~(*upper_block_tf_writemask));