fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 21:50:12 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

broadcom/compiler: use a helper function to decide on TMU spilling

Browse source 
As we add more compiler optimizations that can increase register pressure
we may decide to disallow TMU spilling in more cases so it is probably
better to move this to its own helper function.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9077>
This commit is contained in:
Iago Toral Quiroga 2021-02-16 10:05:14 +01:00
parent 14af7b3085
commit df6c19c1fd
1 changed files with 12 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/broadcom/compiler/vir_register_allocate.c
View file

@ -502,6 +502,17 @@ get_spill_batch_size(struct v3d_compile *c)
return 20;
}
/* Don't emit spills using the TMU until we've dropped thread count first. Also,
* don't spill if we have enabled any other optimization that can lead to
* higher register pressure, such as TMU pipelining, we rather recompile without
* the optimization in that case.
*/
static inline bool
tmu_spilling_allowed(struct v3d_compile *c, int thread_index)
{
return thread_index == 0 && c->disable_tmu_pipelining;
}
#define CLASS_BIT_PHYS (1 << 0)
#define CLASS_BIT_ACC (1 << 1)
#define CLASS_BIT_R5 (1 << 4)
@ -746,13 +757,7 @@ v3d_register_allocate(struct v3d_compile *c, bool *spilled)
if (i > 0 && !is_uniform)
break;
/* Don't emit spills using the TMU until we've dropped
* thread count first. Also, don't spill if we have
* enabled TMU pipelining, as that can make TMU spilling
* pretty terrible.
*/
if (is_uniform ||
(thread_index == 0 && c->disable_tmu_pipelining)) {
if (is_uniform || tmu_spilling_allowed(c, thread_index)) {
v3d_spill_reg(c, map[node].temp);
/* Ask the outer loop to call back in. */