From ddc26666da3b675a0cab8975a68c7ad7e9c05f05 Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Thu, 4 Dec 2025 16:51:48 +0100 Subject: [PATCH] nak: drop clone of Copy-able types (RegOrigin & SSAValue) Part-of: --- src/nouveau/compiler/nak/calc_instr_deps.rs | 4 ++-- src/nouveau/compiler/nak/from_nir.rs | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/nouveau/compiler/nak/calc_instr_deps.rs b/src/nouveau/compiler/nak/calc_instr_deps.rs index 967b70cef07..8ea6b8fa0f7 100644 --- a/src/nouveau/compiler/nak/calc_instr_deps.rs +++ b/src/nouveau/compiler/nak/calc_instr_deps.rs @@ -896,10 +896,10 @@ impl BlockDelayScheduler<'_> { src_dst_idx: u16::MAX, }; reg_uses.for_each_pred(|c| { - c.add_read(read_origin.clone(), 0); + c.add_read(read_origin, 0); }); reg_uses.for_each_carry(|c| { - c.add_read(read_origin.clone(), 0); + c.add_read(read_origin, 0); }); } diff --git a/src/nouveau/compiler/nak/from_nir.rs b/src/nouveau/compiler/nak/from_nir.rs index a95a57d9398..aa7df61fac3 100644 --- a/src/nouveau/compiler/nak/from_nir.rs +++ b/src/nouveau/compiler/nak/from_nir.rs @@ -3251,7 +3251,7 @@ impl<'a> ShaderFromNir<'a> { b.push_op(OpLdSharedLock { dst: dst.clone().into(), - locked: locked.clone().into(), + locked: locked.into(), addr, offset, mem_type, @@ -3675,7 +3675,7 @@ impl<'a> ShaderFromNir<'a> { let locked = b.alloc_ssa(RegFile::Pred); b.push_op(OpStSCheckUnlock { - locked: locked.clone().into(), + locked: locked.into(), addr, data, offset, @@ -3787,7 +3787,7 @@ impl<'a> ShaderFromNir<'a> { let dst = b.alloc_ssa(RegFile::GPR); let src = self.get_src(&srcs[0]); b.push_op(OpMovm { - dst: dst.clone().into(), + dst: dst.into(), src, }); self.set_dst(&intrin.def, dst.into());