glsl: Move type_contains_sampler() into glsl_type for later reuse.

The new location, as a member function of glsl_type, is more
consistent with queries like is_sampler(), is_boolean(), is_float(),
etc.  Placing the function inside glsl_type also makes it available to
any code that uses glsl_types.
This commit is contained in:
Paul Berry 2011-07-11 16:44:13 -07:00
parent 9b3ec69cf4
commit ddc1c96390
3 changed files with 23 additions and 16 deletions

View file

@ -111,6 +111,22 @@ add_types_to_symbol_table(glsl_symbol_table *symtab,
}
}
bool
glsl_type::contains_sampler() const
{
if (this->is_array()) {
return this->fields.array->contains_sampler();
} else if (this->is_record()) {
for (unsigned int i = 0; i < this->length; i++) {
if (this->fields.structure[i].type->contains_sampler())
return true;
}
return false;
} else {
return this->is_sampler();
}
}
void
glsl_type::generate_100ES_types(glsl_symbol_table *symtab)
{

View file

@ -295,6 +295,12 @@ struct glsl_type {
return base_type == GLSL_TYPE_SAMPLER;
}
/**
* Query whether or not type is a sampler, or for struct and array
* types, contains a sampler.
*/
bool contains_sampler() const;
/**
* Query whether or not a type is an array
*/

View file

@ -1095,21 +1095,6 @@ ir_dereference_record::ir_dereference_record(ir_variable *var,
? this->record->type->field_type(field) : glsl_type::error_type;
}
bool type_contains_sampler(const glsl_type *type)
{
if (type->is_array()) {
return type_contains_sampler(type->fields.array);
} else if (type->is_record()) {
for (unsigned int i = 0; i < type->length; i++) {
if (type_contains_sampler(type->fields.structure[i].type))
return true;
}
return false;
} else {
return type->is_sampler();
}
}
bool
ir_dereference::is_lvalue()
{
@ -1129,7 +1114,7 @@ ir_dereference::is_lvalue()
* as out or inout function parameters, nor can they be
* assigned into."
*/
if (type_contains_sampler(this->type))
if (this->type->contains_sampler())
return false;
return true;