From dda7400c0ba46a6259355216d1352a206450cfb1 Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Fri, 19 May 2023 09:20:42 +0200 Subject: [PATCH] radv: disable IMAGE_USAGE_STORAGE with depth-only and stencil-only formats This shouldn't have been enabled at all. Depth-stencil formats were accidentally disabled but not depth-only or stencil-only formats. This doesn't seem allowed by DX12 and both AMD/NVIDIA don't enable it. Cc: mesa-stable Signed-off-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_formats.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c index d9909d8c688..c0e34a56790 100644 --- a/src/amd/vulkan/radv_formats.c +++ b/src/amd/vulkan/radv_formats.c @@ -537,6 +537,9 @@ radv_is_storage_image_format_supported(const struct radv_physical_device *physic if (format == VK_FORMAT_UNDEFINED) return false; + if (vk_format_is_depth_or_stencil(format)) + return false; + data_format = radv_translate_tex_dataformat(format, desc, vk_format_get_first_non_void_channel(format)); num_format =