From dd980d2b288d2845716183dd6819e82d53800a15 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timur=20Krist=C3=B3f?= Date: Wed, 8 Jan 2025 13:32:57 -0600 Subject: [PATCH] radv: Only print "testing use only" message on GFX12+. This message has been confusing users, especially now that popular toolkits such as Gtk started using a Vulkan renderer. Printing a message on non-conformant implementations is also actually not required. So let's remove it. We haven't fully finished the GFX12 implementation yet, but on all other hardware, RADV should work just fine, and is definitely not meant for "testing use only". Cc: mesa-stable Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/12314 Reviewed-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_physical_device.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/amd/vulkan/radv_physical_device.c b/src/amd/vulkan/radv_physical_device.c index 2003ae967ba..f6e088c852f 100644 --- a/src/amd/vulkan/radv_physical_device.c +++ b/src/amd/vulkan/radv_physical_device.c @@ -185,14 +185,6 @@ radv_get_conformance_version(const struct radv_physical_device *pdev) return conformance_version; } -static bool -radv_is_conformant(const struct radv_physical_device *pdev) -{ - VkConformanceVersion conformance_version = radv_get_conformance_version(pdev); - - return conformance_version.major != 0; -} - static void parse_hex(char *out, const char *in, unsigned length) { @@ -2128,7 +2120,7 @@ radv_physical_device_try_create(struct radv_instance *instance, drmDevicePtr drm snprintf(pdev->marketing_name, sizeof(pdev->name), "%s (RADV %s%s)", marketing_name ? marketing_name : "AMD Unknown", pdev->info.name, radv_get_compiler_string(pdev)); - if (!radv_is_conformant(pdev)) + if (pdev->info.gfx_level >= GFX12) vk_warn_non_conformant_implementation("radv"); radv_get_driver_uuid(&pdev->driver_uuid);