From dbf027534a397274ac44f859f41a33b3652ab8ec Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Ol=C5=A1=C3=A1k?= Date: Thu, 19 Mar 2026 22:22:05 -0400 Subject: [PATCH] ac/llvm: inline ac_build_gather_values_extended Reviewed-by: Pierre-Eric Part-of: --- src/amd/llvm/ac_llvm_build.c | 15 ++++----------- src/amd/llvm/ac_llvm_build.h | 3 --- 2 files changed, 4 insertions(+), 14 deletions(-) diff --git a/src/amd/llvm/ac_llvm_build.c b/src/amd/llvm/ac_llvm_build.c index 815831ae3b3..166d46e57fe 100644 --- a/src/amd/llvm/ac_llvm_build.c +++ b/src/amd/llvm/ac_llvm_build.c @@ -492,21 +492,20 @@ LLVMValueRef ac_build_vote_any(struct ac_llvm_context *ctx, LLVMValueRef value) ""); } -LLVMValueRef ac_build_gather_values_extended(struct ac_llvm_context *ctx, LLVMValueRef *values, - unsigned value_count, unsigned value_stride, - bool always_vector) +LLVMValueRef ac_build_gather_values(struct ac_llvm_context *ctx, LLVMValueRef *values, + unsigned value_count) { LLVMBuilderRef builder = ctx->builder; LLVMValueRef vec = NULL; unsigned i; - if (value_count == 1 && !always_vector) { + if (value_count == 1) { return values[0]; } else if (!value_count) UNREACHABLE("value_count is 0"); for (i = 0; i < value_count; i++) { - LLVMValueRef value = values[i * value_stride]; + LLVMValueRef value = values[i]; if (!i) vec = LLVMGetUndef(LLVMVectorType(LLVMTypeOf(value), value_count)); @@ -516,12 +515,6 @@ LLVMValueRef ac_build_gather_values_extended(struct ac_llvm_context *ctx, LLVMVa return vec; } -LLVMValueRef ac_build_gather_values(struct ac_llvm_context *ctx, LLVMValueRef *values, - unsigned value_count) -{ - return ac_build_gather_values_extended(ctx, values, value_count, 1, false); -} - LLVMValueRef ac_build_concat(struct ac_llvm_context *ctx, LLVMValueRef a, LLVMValueRef b) { if (!a) diff --git a/src/amd/llvm/ac_llvm_build.h b/src/amd/llvm/ac_llvm_build.h index cbd06d16453..9866b6dcad7 100644 --- a/src/amd/llvm/ac_llvm_build.h +++ b/src/amd/llvm/ac_llvm_build.h @@ -184,9 +184,6 @@ LLVMValueRef ac_build_vote_all(struct ac_llvm_context *ctx, LLVMValueRef value); LLVMValueRef ac_build_vote_any(struct ac_llvm_context *ctx, LLVMValueRef value); -LLVMValueRef ac_build_gather_values_extended(struct ac_llvm_context *ctx, LLVMValueRef *values, - unsigned value_count, unsigned value_stride, - bool always_vector); LLVMValueRef ac_build_gather_values(struct ac_llvm_context *ctx, LLVMValueRef *values, unsigned value_count);