mirror of
https://gitlab.freedesktop.org/mesa/mesa.git
synced 2026-05-04 20:38:06 +02:00
radv: report error messages when the driver can't be initialized
Not only with RADV_DEBUG=startup. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13343>
This commit is contained in:
parent
4765edb4e0
commit
db82d90451
1 changed files with 6 additions and 13 deletions
|
|
@ -577,31 +577,24 @@ radv_physical_device_try_create(struct radv_instance *instance, drmDevicePtr drm
|
|||
|
||||
fd = open(path, O_RDWR | O_CLOEXEC);
|
||||
if (fd < 0) {
|
||||
if (instance->debug_flags & RADV_DEBUG_STARTUP)
|
||||
radv_logi("Could not open device '%s'", path);
|
||||
|
||||
return vk_error(instance, VK_ERROR_INCOMPATIBLE_DRIVER);
|
||||
return vk_errorf(instance, VK_ERROR_INCOMPATIBLE_DRIVER,
|
||||
"Could not open device %s: %m", path);
|
||||
}
|
||||
|
||||
version = drmGetVersion(fd);
|
||||
if (!version) {
|
||||
close(fd);
|
||||
|
||||
if (instance->debug_flags & RADV_DEBUG_STARTUP)
|
||||
radv_logi("Could not get the kernel driver version for device '%s'", path);
|
||||
|
||||
return vk_errorf(instance, VK_ERROR_INCOMPATIBLE_DRIVER, "failed to get version %s: %m",
|
||||
path);
|
||||
return vk_errorf(instance, VK_ERROR_INCOMPATIBLE_DRIVER,
|
||||
"Could not get the kernel driver version for device %s: %m", path);
|
||||
}
|
||||
|
||||
if (strcmp(version->name, "amdgpu")) {
|
||||
drmFreeVersion(version);
|
||||
close(fd);
|
||||
|
||||
if (instance->debug_flags & RADV_DEBUG_STARTUP)
|
||||
radv_logi("Device '%s' is not using the amdgpu kernel driver.", path);
|
||||
|
||||
return VK_ERROR_INCOMPATIBLE_DRIVER;
|
||||
return vk_errorf(instance, VK_ERROR_INCOMPATIBLE_DRIVER,
|
||||
"Device '%s' is not using the AMDGPU kernel driver: %m", path);
|
||||
}
|
||||
drmFreeVersion(version);
|
||||
|
||||
|
|
|
|||
Loading…
Add table
Reference in a new issue