panfrost: Remove NO_TILE_ENABLE_MAP quirk

Function of architecture. Add a comment to the sole consumer of the quirk bit
about why it's used.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14724>
This commit is contained in:
Alyssa Rosenzweig 2022-01-25 17:51:48 -05:00 committed by Marge Bot
parent bbe0517481
commit db497c27dc
2 changed files with 8 additions and 7 deletions

View file

@ -573,8 +573,12 @@ panfrost_resource_set_damage_region(struct pipe_screen *screen,
struct pipe_scissor_state *damage_extent = &pres->damage.extent;
unsigned int i;
if (!pan_is_bifrost(dev) && !(dev->quirks & NO_TILE_ENABLE_MAP) &&
nrects > 1) {
/* Partial updates are implemented with a tile enable map only on v5.
* Later architectures have a more efficient method of implementing
* partial updates (frame shaders), while earlier architectures lack
* tile enable maps altogether.
*/
if (dev->arch == 5 && nrects > 1) {
if (!pres->damage.tile_map.data) {
pres->damage.tile_map.stride =
ALIGN_POT(DIV_ROUND_UP(res->width0, 32 * 8), 64);

View file

@ -54,8 +54,6 @@
/* Does this GPU support anisotropic filtering? */
#define HAS_ANISOTROPIC (1 << 11)
#define NO_TILE_ENABLE_MAP (1 << 12)
/* Quirk collections common to particular uarchs */
#define MIDGARD_QUIRKS (MIDGARD_NO_TYPED_BLEND_STORES | MIDGARD_MISSING_LOADS)
@ -70,11 +68,10 @@ panfrost_get_quirks(unsigned gpu_id, unsigned gpu_revision)
case 0x620:
return MIDGARD_QUIRKS
| MIDGARD_NO_TYPED_BLEND_LOADS
| NO_BLEND_PACKS | NO_TILE_ENABLE_MAP;
| NO_BLEND_PACKS;
case 0x720:
return MIDGARD_QUIRKS | MIDGARD_NO_HIER_TILING
| NO_TILE_ENABLE_MAP;
return MIDGARD_QUIRKS | MIDGARD_NO_HIER_TILING;
case 0x820:
case 0x830: