fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-15 11:40:39 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

intel/isl: Don't scream FINISHME into logs for 3D vs. CCS

Browse source 
This would probably be a nice optimisation to have, but it really does
make the CTS logs awful:
    https://gitlab.freedesktop.org/mesa/mesa/-/jobs/37692447

Just demote this isl_finishme() to a comment; given it's been unfinished
since 2019, we can probably live without it.

Fixes: 126c9562d9 ("isl: Redefine the CCS layout for Gen12")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/21788>
This commit is contained in:
Daniel Stone 2023-03-08 15:03:35 +00:00 • committed by Marge Bot
parent df7b40d002
commit daa1468b54
1 changed files with 2 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/intel/isl/isl.c
View file

@ -2234,14 +2234,11 @@ isl_surf_supports_ccs(const struct isl_device *dev,
if (surf->row_pitch_B % 512 != 0)
return false;
/* According to Wa_1406738321, 3D textures need a blit to a new
/* TODO: According to Wa_1406738321, 3D textures need a blit to a new
* surface in order to perform a resolve. For now, just disable CCS.
*/
if (surf->dim == ISL_SURF_DIM_3D) {
isl_finishme("%s:%s: CCS for 3D textures is disabled, but a workaround"
" is available.", __FILE__, __func__);
if (surf->dim == ISL_SURF_DIM_3D)
return false;
}
/* Wa_1207137018
*