fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 02:48:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

iris: Fix an assertion failure with compressed format

Browse source 
Fixes: ext_texture_array-compressed teximage pbo -fbo -auto

src/gallium/drivers/iris/iris_state.c:3142: iris_create_surface:
Assertion `res->aux.usage == ISL_AUX_USAGE_NONE' failed

Suggested by Nanley Chery <nanley.g.chery@intel.com>

Backport-to: 24.2
Signed-off-by: Jianxun Zhang <jianxun.zhang@intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30111>
(cherry picked from commit 6b4def143c)
This commit is contained in:
Jianxun Zhang 2024-07-26 11:25:42 -07:00 • committed by Eric Engestrom
parent 3c586ea1b8
commit da6e9fcdfd
2 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -284,7 +284,7 @@
"description": "iris: Fix an assertion failure with compressed format", "description": "iris: Fix an assertion failure with compressed format",
"nominated": true, "nominated": true,
"nomination_type": 4, "nomination_type": 4,
"resolution": 0, "resolution": 1,
"main_sha": null, "main_sha": null,
"because_sha": null, "because_sha": null,
"notes": null "notes": null

4
src/gallium/drivers/iris/iris_state.c
View file

@ -3135,11 +3135,11 @@ iris_create_surface(struct pipe_context *ctx,
* have a renderable view format. We must be attempting to upload * have a renderable view format. We must be attempting to upload
* blocks of compressed data via an uncompressed view. * blocks of compressed data via an uncompressed view.
* *
* In this case, we can assume there are no auxiliary buffers, a single * In this case, we can assume there are no auxiliary surfaces, a single
* miplevel, and that the resource is single-sampled. Gallium may try * miplevel, and that the resource is single-sampled. Gallium may try
* and create an uncompressed view with multiple layers, however. * and create an uncompressed view with multiple layers, however.
*/ */
assert(res->aux.usage == ISL_AUX_USAGE_NONE); assert(res->aux.surf.size_B == 0);
assert(res->surf.samples == 1); assert(res->surf.samples == 1);
assert(view->levels == 1); assert(view->levels == 1);