fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-17 01:40:36 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

aco/ra: consider already-used preserved registers to be free

Browse source 
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38679>
This commit is contained in:
Rhys Perry 2026-01-16 17:22:09 +00:00 • committed by Marge Bot
parent 103160ff2f
commit da1dca28a7
1 changed files with 24 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
src/amd/compiler/aco_register_allocation.cpp
View file

@ -3972,6 +3972,11 @@ register_allocation(Program* program, ra_test_policy policy)
ctx.assignments[definition.tempId()].set(definition);
register_file.fill(definition);
if (instr->opcode != aco_opcode::p_startpgm) {
for (unsigned j = 0; j < definition.size(); j++)
BITSET_CLEAR(ctx.preserved, definition.physReg() + j);
}
}
/* handle normal definitions */
@ -3981,6 +3986,8 @@ register_allocation(Program* program, ra_test_policy policy)
if (definition->isFixed() || !definition->isTemp() || i < tied_defs.size())
continue;
bool clear_preserved = instr->opcode != aco_opcode::p_startpgm;
/* find free reg */
if (instr->opcode == aco_opcode::p_start_linear_vgpr ||
(instr->opcode == aco_opcode::p_startpgm &&
@ -3995,6 +4002,7 @@ register_allocation(Program* program, ra_test_policy policy)
reg.reg_b += instr->definitions[j].bytes();
if (get_reg_specified(ctx, register_file, rc, instr, reg, -1, false)) {
definition->setFixed(reg);
clear_preserved = false;
} else if (i == 0) {
RegClass vec_rc = RegClass::get(rc.type(), instr->operands[0].bytes());
DefInfo info(ctx, ctx.pseudo_dummy, vec_rc, -1);
@ -4013,14 +4021,18 @@ register_allocation(Program* program, ra_test_policy policy)
PhysReg reg = instr->operands[i].physReg();
if (instr->operands[i].isTemp() &&
instr->operands[i].getTemp().type() == definition->getTemp().type() &&
!register_file.test(reg, definition->bytes()))
!register_file.test(reg, definition->bytes())) {
definition->setFixed(reg);
clear_preserved = false;
}
} else if (instr->opcode == aco_opcode::p_extract_vector) {
PhysReg reg = instr->operands[0].physReg();
reg.reg_b += definition->bytes() * instr->operands[1].constantValue();
if (get_reg_specified(ctx, register_file, definition->regClass(), instr, reg, -1,
false))
false)) {
definition->setFixed(reg);
clear_preserved = false;
}
} else if (instr->opcode == aco_opcode::p_create_vector) {
PhysReg reg = get_reg_create_vector(ctx, register_file, definition->getTemp(),
parallelcopy, instr);
@ -4056,6 +4068,11 @@ register_allocation(Program* program, ra_test_policy policy)
(definition->getTemp().type() != RegType::vgpr && definition->physReg() < 256)));
ctx.assignments[definition->tempId()].set(*definition);
register_file.fill(*definition);
if (clear_preserved) {
for (unsigned j = 0; j < definition->size(); j++)
BITSET_CLEAR(ctx.preserved, definition->physReg() + j);
}
}
if (!ctx.vector_operands.empty())
@ -4082,6 +4099,11 @@ register_allocation(Program* program, ra_test_policy policy)
add_subdword_operand(ctx, instr, i, op.physReg().byte(), op.regClass());
}
for (auto copy : parallelcopy) {
for (unsigned j = 0; j < copy.def.size(); j++)
BITSET_CLEAR(ctx.preserved, copy.def.physReg() + j);
}
emit_parallel_copy(ctx, parallelcopy, instr, instructions, temp_in_scc, register_file);
for (auto split : vector_splits)