fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-11 14:30:26 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

aco/ra: disable live range splitting of linear vgprs

Browse source 
These shouldn't happen anymore.

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/27697>
This commit is contained in:
Rhys Perry 2024-01-29 19:58:32 +00:00 • committed by Marge Bot
parent b7738de4f9
commit d9b69a7cbf
1 changed files with 7 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/amd/compiler/aco_register_allocation.cpp
View file

@ -1214,9 +1214,8 @@ get_regs_for_copies(ra_ctx& ctx, RegisterFile& reg_file,
n++;
continue;
}
/* we cannot split live ranges of linear vgprs inside control flow */
if (!(ctx.block->kind & block_kind_top_level) &&
ctx.assignments[reg_file[j]].rc.is_linear_vgpr()) {
/* we cannot split live ranges of linear vgprs */
if (ctx.assignments[reg_file[j]].rc.is_linear_vgpr()) {
found = false;
break;
}
@ -1363,10 +1362,8 @@ get_reg_impl(ra_ctx& ctx, const RegisterFile& reg_file,
break;
}
/* we cannot split live ranges of linear vgprs inside control flow */
// TODO: ensure that live range splits inside control flow are never necessary
if (!(ctx.block->kind & block_kind_top_level) &&
ctx.assignments[reg_file[j]].rc.is_linear_vgpr()) {
/* we cannot split live ranges of linear vgprs */
if (ctx.assignments[reg_file[j]].rc.is_linear_vgpr()) {
found = false;
break;
}
@ -1967,13 +1964,9 @@ get_reg_create_vector(ra_ctx& ctx, const RegisterFile& reg_file, Temp temp,
avoid |= ctx.war_hint[j];
}
if (linear_vgpr) {
/* we cannot split live ranges of linear vgprs inside control flow */
if (ctx.block->kind & block_kind_top_level)
avoid = true;
else
continue;
}
/* we cannot split live ranges of linear vgprs */
if (linear_vgpr)
continue;
if (avoid && !best_avoid)
continue;