fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 20:08:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

frontends/va: Fix missing unlock

Browse source 
Fix defect reported by Coverity Scan.

Missing unlock (LOCK)
missing_unlock: Returning without unlocking drv->mutex.

Fixes: af695149e9 ("frontends/va: pass in film_grain_target as new output")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Boyuan Zhang <Boyuan.Zhang@amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23488>
(cherry picked from commit e1d948b6a2)
This commit is contained in:
Vinson Lee 2023-06-06 23:16:19 -07:00 • committed by Eric Engestrom
parent 631fa4a8d6
commit d98d6e0e1c
2 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -2623,7 +2623,7 @@
"description": "frontends/va: Fix missing unlock",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "af695149e96bf276b52ff3715076ddc847c6b959"
},

4
src/gallium/frontends/va/picture.c
View file

@ -877,8 +877,10 @@ vlVaEndPicture(VADriverContextP ctx, VAContextID context_id)
mtx_lock(&drv->mutex);
surf = handle_table_get(drv->htab, output_id);
if (!surf || !surf->buffer)
if (!surf || !surf->buffer) {
mtx_unlock(&drv->mutex);
return VA_STATUS_ERROR_INVALID_SURFACE;
}
if (apply_av1_fg) {
surf->ctx = context_id;