ci: Drop hardware-job prerequisite check jobs

Stop requiring the `rustfmt` and `yaml-toml-shell-py-test` jobs before
starting hardware jobs.
These prerequisites don't save meaningful resources, as the hardware jobs
are well-behaved nowadays, but they do create unnecessary friction for
users.

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/14409
Signed-off-by: Valentine Burley <valentine.burley@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38786>

.gitlab-ci/bare-metal/gitlab-ci.yml

@@ -31,7 +31,6 @@
       optional: true
     - job: debian-arm32
       artifacts: false
-    - !reference [.required-for-hardware-jobs, needs]
 
 # ARM64 testing of bare-metal boards attached to an x86 gitlab-runner system
 .baremetal-test-arm64-gl:
@@ -46,7 +45,6 @@
       optional: true
     - job: debian-arm64
       artifacts: false
-    - !reference [.required-for-hardware-jobs, needs]
 
 # ARM64 testing of bare-metal boards attached to an x86 gitlab-runner system
 .baremetal-test-arm64-vk:
@@ -61,7 +59,6 @@
       optional: true
     - job: debian-arm64
       artifacts: false
-    - !reference [.required-for-hardware-jobs, needs]
 
 # ARM32/64 testing of bare-metal boards attached to an x86 gitlab-runner system, using an asan mesa build
 .baremetal-arm32-asan-test-gl:
@@ -73,7 +70,6 @@
       optional: true
     - job: debian-arm32-asan
       artifacts: false
-    - !reference [.required-for-hardware-jobs, needs]
 
 .baremetal-arm64-asan-test-gl:
   variables:
@@ -84,7 +80,6 @@
       optional: true
     - job: debian-arm64-asan
       artifacts: false
-    - !reference [.required-for-hardware-jobs, needs]
 
 .baremetal-arm64-asan-test-vk:
   variables:
@@ -95,7 +90,6 @@
       optional: true
     - job: debian-arm64-asan
       artifacts: false
-    - !reference [.required-for-hardware-jobs, needs]
 
 .baremetal-arm64-ubsan-test-gl:
   extends:
@@ -108,7 +102,6 @@
       optional: true
     - job: debian-arm64-ubsan
       artifacts: false
-    - !reference [.required-for-hardware-jobs, needs]
 
 .baremetal-arm64-ubsan-test-vk:
   extends:
@@ -121,7 +114,6 @@
       optional: true
     - job: debian-arm64-ubsan
       artifacts: false
-    - !reference [.required-for-hardware-jobs, needs]
 
 .baremetal-deqp-test:
   variables:

.gitlab-ci/ci-tron/gitlab-ci.yml

@@ -36,8 +36,6 @@
 
     # Keep the job script in the artifacts
     CI_TRON_JOB_SCRIPT_PATH: results/job_script.sh
-  needs:
-    - !reference [.required-for-hardware-jobs, needs]
   tags:
     - farm:$RUNNER_FARM_LOCATION
     - ci-tron:priority:$CI_TRON_JOB_PRIORITY
@@ -97,7 +95,6 @@
       optional: true
     - job: debian-x86_64
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-x86_64-test-vk-manual:
   extends:
@@ -111,7 +108,6 @@
       optional: true
     - job: debian-build-x86_64
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-x86_64-test-gl:
   extends:
@@ -123,7 +119,6 @@
       optional: true
     - job: debian-x86_64
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-x86_64-test-gl-manual:
   extends:
@@ -137,7 +132,6 @@
       optional: true
     - job: debian-build-x86_64
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-arm64-test:
   extends:
@@ -157,7 +151,6 @@
       optional: true
     - job: debian-arm64
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-arm64-test-asan-vk:
   extends:
@@ -172,7 +165,6 @@
       optional: true
     - job: debian-arm64-asan
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-arm64-test-ubsan-vk:
   extends:
@@ -186,7 +178,6 @@
       optional: true
     - job: debian-arm64-ubsan
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-arm64-test-gl:
   extends:
@@ -198,7 +189,6 @@
       optional: true
     - job: debian-arm64
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-arm64-test-asan-gl:
   extends:
@@ -213,7 +203,6 @@
       optional: true
     - job: debian-arm64-asan
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-arm64-test-ubsan-gl:
   extends:
@@ -227,7 +216,6 @@
       optional: true
     - job: debian-arm64-ubsan
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-arm32-test:
   extends:
@@ -247,7 +235,6 @@
       optional: true
     - job: debian-arm32
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-arm32-test-gl:
   extends:
@@ -259,7 +246,6 @@
       optional: true
     - job: debian-arm32
       artifacts: false
-    - !reference [.ci-tron-test, needs]
 
 .ci-tron-arm32-test-asan-gl:
   extends:
@@ -274,4 +260,3 @@
       optional: true
     - job: debian-arm32-asan
       artifacts: false
-    - !reference [.ci-tron-test, needs]

.gitlab-ci/lava/gitlab-ci.yml

@@ -66,8 +66,6 @@ variables:
     - $RUNNER_TAG
   after_script:
     - curl -L --retry 4 -f --retry-connrefused --retry-delay 30 -s "https://${JOB_RESULTS_PATH}" | tar --warning=no-timestamp --zstd -x
-  needs:
-    - !reference [.required-for-hardware-jobs, needs]
 
 .lava-x86_64-test:
   extends:
@@ -89,7 +87,6 @@ variables:
     HWCI_TEST_SCRIPT: install/cuttlefish-runner.sh
     S3_ANDROID_ARTIFACT_NAME: mesa-x86_64-android-debug
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/x86_64_test-android
       artifacts: false
       optional: true
@@ -103,7 +100,6 @@ variables:
     - .use-debian/x86_64_test-gl
     - .lava-x86_64-test
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/x86_64_test-gl
       artifacts: false
       optional: true
@@ -118,7 +114,6 @@ variables:
     DEQP_FORCE_ASAN: 1
     S3_ARTIFACT_NAME: mesa-x86_64-asan-debugoptimized
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/x86_64_test-gl
       artifacts: false
       optional: true
@@ -130,7 +125,6 @@ variables:
     - .use-debian/x86_64_test-video
     - .lava-x86_64-test
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/x86_64_test-video
       artifacts: false
       optional: true
@@ -142,7 +136,6 @@ variables:
     - .use-debian/x86_64_test-vk
     - .lava-x86_64-test
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/x86_64_test-vk
       artifacts: false
       optional: true
@@ -157,7 +150,6 @@ variables:
     DEQP_FORCE_ASAN: 1
     S3_ARTIFACT_NAME: mesa-x86_64-asan-debugoptimized
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/x86_64_test-vk
       artifacts: false
       optional: true
@@ -179,7 +171,6 @@ variables:
     - .use-debian/arm32_test-gl
     - .lava-arm32-test
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/arm32_test-gl
       artifacts: false
       optional: true
@@ -201,7 +192,6 @@ variables:
     - .use-debian/arm64_test-gl
     - .lava-arm64-test
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/arm64_test-gl
       artifacts: false
       optional: true
@@ -216,7 +206,6 @@ variables:
     DEQP_FORCE_ASAN: 1
     S3_ARTIFACT_NAME: mesa-arm64-asan-debugoptimized
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/arm64_test-gl
       artifacts: false
       optional: true
@@ -228,7 +217,6 @@ variables:
     - .use-debian/arm64_test-vk
     - .lava-arm64-test
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/arm64_test-vk
       artifacts: false
       optional: true
@@ -243,7 +231,6 @@ variables:
     DEQP_FORCE_ASAN: 1
     S3_ARTIFACT_NAME: mesa-arm64-asan-debugoptimized
   needs:
-    - !reference [.lava-test, needs]
     - job: debian/arm64_test-vk
       artifacts: false
       optional: true

.gitlab-ci/test/gitlab-ci-inc.yml

@@ -41,7 +41,6 @@
     - job: debian/x86_64_test-gl
       optional: true
     - job: debian-x86_64
-    - !reference [.required-for-hardware-jobs, needs]
   variables:
     DEBIAN_ARCH: amd64
     S3_ARTIFACT_NAME: mesa-x86_64-default-debugoptimized
@@ -54,7 +53,6 @@
     - job: debian-x86_64
     - job: debian/x86_64_test-vk
       optional: true
-    - !reference [.required-for-hardware-jobs, needs]
   variables:
     DEBIAN_ARCH: amd64
     S3_ARTIFACT_NAME: mesa-x86_64-default-debugoptimized
@@ -66,7 +64,6 @@
   needs:
     - job: debian/x86_64_test-gl
       optional: true
-    - !reference [.required-for-hardware-jobs, needs]
   variables:
     S3_ARTIFACT_NAME: mesa-x86_64-default-debugoptimized
 
@@ -91,7 +88,6 @@
     - job: debian/x86_64_test-android
       artifacts: false
       optional: true
-    - !reference [.required-for-hardware-jobs, needs]
   timeout: 20m
   script:
     - ./install/cuttlefish-runner.sh
@@ -182,13 +178,3 @@
     - rm -rf install
     - (set -x; curl -L --retry 4 -f --retry-all-errors --retry-delay 60 ${FDO_HTTP_CACHE_URI:-}https://${PIPELINE_ARTIFACTS_BASE}/${S3_ARTIFACT_NAME}.tar.zst | tar --zstd -x)
     - section_end artifacts_download
-
-# Jobs that need to pass before spending hardware resources on further testing
-.required-for-hardware-jobs:
-  needs:
-    - job: rustfmt
-      optional: true
-      artifacts: false
-    - job: yaml-toml-shell-py-test
-      optional: true
-      artifacts: false

src/gallium/drivers/d3d12/ci/gitlab-ci-inc.yml

@@ -9,7 +9,6 @@
     - job: windows-msvc
     - job: windows_test_msvc
       optional: true
-    - !reference [.required-for-hardware-jobs, needs]
   variables:
     GIT_STRATEGY: none # testing doesn't build anything from source
     GALLIUM_DRIVER: d3d12

src/microsoft/ci/gitlab-ci.yml

@@ -13,7 +13,6 @@ test-spirv2dxil-windows:
     - job: windows-msvc
     - job: windows_test_msvc
       optional: true
-    - !reference [.required-for-hardware-jobs, needs]
   variables:
     GIT_STRATEGY: none # testing doesn't build anything from source
   script:
@@ -36,7 +35,6 @@ test-dozen-deqp:
     - job: windows-msvc
     - job: windows_test_msvc
       optional: true
-    - !reference [.required-for-hardware-jobs, needs]
   variables:
     GIT_STRATEGY: none # testing doesn't build anything from source
     DZN_AGILITY_RELATIVE_PATH: "D3D12\\"