fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-15 09:30:19 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

aco/spill: use spills_entry instead of spills_exit to kill linear VGPRs

Browse source 
If a predecessor has only spilled constants (no temporaries), spills_exit
will be empty.

fossil-db (Sienna Cichlid):
Totals from 2 (0.00% of 128647) affected shaders:
Latency: 139106 -> 139104 (-0.00%)

Signed-off-by: Rhys Perry <pendingchaos02@gmail.com>
Reviewed-by: Daniel Schürmann <daniel@schuermann.dev>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5633
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13821>
(cherry picked from commit cc2894345f)
This commit is contained in:
Rhys Perry 2021-11-16 17:33:11 +00:00 • committed by Dylan Baker
parent 267ffbcc98
commit d8ec092e01
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -553,7 +553,7 @@
"description": "aco/spill: use spills_entry instead of spills_exit to kill linear VGPRs",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null
},

2
src/amd/compiler/aco_spill.cpp
View file

@ -1563,7 +1563,7 @@ assign_spill_slots(spill_ctx& ctx, unsigned spills_to_vgpr)
continue;
bool can_destroy = true;
for (std::pair<Temp, uint32_t> pair : ctx.spills_exit[block.linear_preds[0]]) {
for (std::pair<Temp, uint32_t> pair : ctx.spills_entry[block.index]) {
if (ctx.interferences[pair.second].first.type() == RegType::sgpr &&
slots[pair.second] / ctx.wave_size == i) {