fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-25 13:00:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

panfrost: Add helper to emit UBOs

Browse source 
Either as uniform remap table entries on Bifrost, or as simple buffer
descriptors on Valhall. The underlying hardware is different (and there are
compiler changes for load_ubo handling), but the high level UBO upload logic
does not have to care about that.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16035>
This commit is contained in:
Alyssa Rosenzweig 2022-04-07 11:26:30 -04:00 • committed by Marge Bot
parent bfbce9c1d9
commit d7b3532553
1 changed files with 29 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
src/gallium/drivers/panfrost/pan_cmdstream.c
View file

@ -1331,6 +1331,35 @@ panfrost_map_constant_buffer_cpu(struct panfrost_context *ctx,
unreachable("No constant buffer");
}
/* Emit a single UBO record. On Valhall, UBOs are dumb buffers and are
* implemented with buffer descriptors in the resource table, sized in terms of
* bytes. On Bifrost and older, UBOs have special uniform buffer data
* structure, sized in terms of entries.
*/
static void
panfrost_emit_ubo(void *base, unsigned index, mali_ptr address, size_t size)
{
#if PAN_ARCH >= 9
struct mali_buffer_packed *out = base;
pan_pack(out + index, BUFFER, cfg) {
cfg.size = size;
cfg.address = address;
}
#else
struct mali_uniform_buffer_packed *out = base;
/* Issue (57) for the ARB_uniform_buffer_object spec says that
* the buffer can be larger than the uniform data inside it,
* so clamp ubo size to what hardware supports. */
pan_pack(out + index, UNIFORM_BUFFER, cfg) {
cfg.entries = MIN2(DIV_ROUND_UP(size, 16), 1 << 12);
cfg.pointer = address;
}
#endif
}
static mali_ptr
panfrost_emit_const_buf(struct panfrost_batch *batch,
enum pipe_shader_type stage,