fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-07 20:08:06 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

lavapipe: more fixes for sample shading

Browse source 
this fixes the case where a draw without sample shading precedes
a draw with sample shading without changes to the sample mask

Fixes: cc9e958053 ("lavapipe: fix DS3 min sample setting")

Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23663>
(cherry picked from commit cb03191e82)
This commit is contained in:
Mike Blumenkrantz 2023-06-14 08:28:07 -04:00 • committed by Eric Engestrom
parent 5e54b211e3
commit d7839ab2a7
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -1435,7 +1435,7 @@
"description": "lavapipe: more fixes for sample shading",
"nominated": true,
"nomination_type": 1,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": "cc9e958053183a9507e40be02cd7decfef1c45d0"
},

3
src/gallium/frontends/lavapipe/lvp_execute.c
View file

@ -1022,6 +1022,7 @@ static void handle_graphics_pipeline(struct vk_cmd_queue_entry *cmd,
state->force_min_sample = pipeline->force_min_sample;
state->sample_shading = ps->ms->sample_shading_enable;
state->min_sample_shading = ps->ms->min_sample_shading;
state->min_samples_dirty = true;
state->blend_dirty = true;
if (!BITSET_TEST(ps->dynamic, MESA_VK_DYNAMIC_MS_RASTERIZATION_SAMPLES))
update_samples(state, ps->ms->rasterization_samples);
@ -1034,7 +1035,7 @@ static void handle_graphics_pipeline(struct vk_cmd_queue_entry *cmd,
if (!BITSET_TEST(ps->dynamic, MESA_VK_DYNAMIC_MS_SAMPLE_MASK)) {
state->sample_mask_dirty = state->sample_mask != 0xffffffff;
state->sample_mask = 0xffffffff;
state->min_samples_dirty = state->min_samples;
state->min_samples_dirty = !!state->min_samples;
state->min_samples = 0;
}
state->blend_dirty |= state->blend_state.alpha_to_coverage || state->blend_state.alpha_to_one;