fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-03 05:38:16 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

freedreno: comment for _invalidate_batch()

Browse source 
Signed-off-by: Rob Clark <robdclark@gmail.com>
This commit is contained in:
Rob Clark 2018-07-17 09:42:27 -04:00
parent f2570409f9
commit d77fcdeb59
1 changed files with 13 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
src/gallium/drivers/freedreno/freedreno_batch_cache.c
View file

@ -199,8 +199,18 @@ fd_bc_invalidate_context(struct fd_context *ctx)
mtx_unlock(&ctx->screen->lock);
}
/**
* Note that when batch is flushed, it needs to remain in the cache so
* that fd_bc_invalidate_resource() can work.. otherwise we can have
* the case where a rsc is destroyed while a batch still has a dangling
* reference to it.
*
* Note that the cmdstream (or, after the SUBMIT ioctl, the kernel)
* would have a reference to the underlying bo, so it is ok for the
* rsc to be destroyed before the batch.
*/
void
fd_bc_invalidate_batch(struct fd_batch *batch, bool destroy)
fd_bc_invalidate_batch(struct fd_batch *batch, bool remove)
{
if (!batch)
return;
@ -208,9 +218,9 @@ fd_bc_invalidate_batch(struct fd_batch *batch, bool destroy)
struct fd_batch_cache *cache = &batch->ctx->screen->batch_cache;
struct key *key = (struct key *)batch->key;
pipe_mutex_assert_locked(batch->ctx->screen->lock);
fd_context_assert_locked(batch->ctx);
if (destroy) {
if (remove) {
cache->batches[batch->idx] = NULL;
cache->batch_mask &= ~(1 << batch->idx);
}