fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-21 00:00:22 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

pan/bi: Lower some 8-bit swizzles

Browse source 
Fixes the 8-bit portion of OpenCL's integer_ops.integer_clz test case.

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18656>
This commit is contained in:
Alyssa Rosenzweig 2022-06-22 16:52:58 -04:00 • committed by Marge Bot
parent d471b386c1
commit d76c48103f
1 changed files with 23 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
src/panfrost/bifrost/bi_lower_swizzle.c
View file

@ -31,12 +31,8 @@
*/
static void
bi_lower_swizzle_16(bi_context *ctx, bi_instr *ins, unsigned src)
lower_swizzle(bi_context *ctx, bi_instr *ins, unsigned src)
{
/* Identity is ok */
if (ins->src[src].swizzle == BI_SWIZZLE_H01)
return;
/* TODO: Use the opcode table and be a lot more methodical about this... */
switch (ins->op) {
/* Some instructions used with 16-bit data never have swizzles */
@ -91,6 +87,18 @@ bi_lower_swizzle_16(bi_context *ctx, bi_instr *ins, unsigned src)
else
break;
/* No swizzles supported */
case BI_OPCODE_HADD_V4U8:
case BI_OPCODE_HADD_V4S8:
case BI_OPCODE_CLZ_V4U8:
case BI_OPCODE_IDP_V4I8:
case BI_OPCODE_IABS_V4S8:
case BI_OPCODE_ICMP_V4I8:
case BI_OPCODE_ICMP_V4U8:
case BI_OPCODE_MUX_V4I8:
case BI_OPCODE_IADD_IMM_V4I8:
break;
/* We don't want to deal with reswizzling logic in modifier prop. Move
* the swizzle outside, it's easier for clamp propagation. */
case BI_OPCODE_FCLAMP_V2F16:
@ -132,7 +140,12 @@ bi_lower_swizzle_16(bi_context *ctx, bi_instr *ins, unsigned src)
/* Lower it away */
bi_builder b = bi_init_builder(ctx, bi_before_instr(ins));
bi_replace_src(ins, src, bi_swz_v2i16(&b, ins->src[src]));
bool is_8 = (bi_opcode_props[ins->op].size == BI_SIZE_8);
bi_index orig = ins->src[src];
bi_index swz = is_8 ? bi_swz_v4i8(&b, orig) : bi_swz_v2i16(&b, orig);
bi_replace_src(ins, src, swz);
ins->src[src].swizzle = BI_SWIZZLE_H01;
}
@ -241,8 +254,10 @@ bi_lower_swizzle(bi_context *ctx)
{
bi_foreach_instr_global_safe(ctx, ins) {
bi_foreach_src(ins, s) {
if (!bi_is_null(ins->src[s]))
bi_lower_swizzle_16(ctx, ins, s);
if (bi_is_null(ins->src[s])) continue;
if (ins->src[s].swizzle == BI_SWIZZLE_H01) continue;
lower_swizzle(ctx, ins, s);
}
}