fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-17 13:30:20 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

brw: fix SIMD lowering of fp16 sampler message data with multiple components
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
Fixes: 61d6aea4 ("brw: fix SIMD lowering of sampler messages with fp16 data")
Closes: mesa/mesa#13149
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/38455>
This commit is contained in:
Calder Young 2025-11-14 13:37:51 -08:00 • committed by Marge Bot
parent c12fa4bf8b
commit d6fbbfef5c
1 changed files with 25 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

38
src/intel/compiler/brw/brw_lower_simd_width.cpp
View file

@ -597,12 +597,23 @@ emit_zip(const brw_builder &lbld_before, const brw_builder &lbld_after,
(reg_unit(devinfo) * REG_SIZE) : 0;
const unsigned dst_size = (inst->size_written - residency_size) /
inst->dst.component_size(inst->exec_size);
unsigned tmp_comp_size;
brw_reg tmp;
/* For SEND messages, align the allocation to physical registers */
const brw_reg tmp = lbld_after.vgrf(
inst->dst.type,
(is_send_inst(inst) ? align(dst_size, reg_unit(devinfo)) : dst_size) +
inst->has_sampler_residency() * reg_unit(devinfo));
if (is_send_inst(inst)) {
/* For SEND messages, align the allocation to physical registers */
tmp_comp_size =
align(inst->dst.component_size(lbld_after.dispatch_width()),
reg_unit(devinfo) * REG_SIZE);
const unsigned tmp_size =
(dst_size * tmp_comp_size + residency_size) / REG_SIZE;
tmp = retype(brw_allocate_vgrf_units(*lbld_after.shader, tmp_size),
inst->dst.type);
} else {
tmp_comp_size = inst->dst.component_size(lbld_after.dispatch_width());
tmp = lbld_after.vgrf(inst->dst.type, dst_size +
inst->has_sampler_residency() * reg_unit(devinfo));
}
if (inst->predicate) {
/* Handle predication by copying the original contents of the
@ -610,7 +621,7 @@ emit_zip(const brw_builder &lbld_before, const brw_builder &lbld_after,
* instruction.
*/
for (unsigned k = 0; k < dst_size; ++k) {
lbld_before.MOV(offset(tmp, lbld_before, k),
lbld_before.MOV(byte_offset(tmp, tmp_comp_size * k),
offset(dst, inst->exec_size, k));
}
}
@ -618,7 +629,7 @@ emit_zip(const brw_builder &lbld_before, const brw_builder &lbld_after,
for (unsigned k = 0; k < dst_size; ++k) {
/* Copy the (split) temp into the original (larger) destination */
lbld_after.MOV(offset(dst, inst->exec_size, k),
offset(tmp, lbld_after, k));
byte_offset(tmp, tmp_comp_size * k));
}
if (inst->has_sampler_residency()) {
@ -745,13 +756,14 @@ brw_lower_simd_width(brw_shader &s)
split_inst->dst = emit_zip(lbld.before(inst),
lbld_after, inst);
/* For SEND messages, align the data size to physical registers */
unsigned data_size =
split_inst->dst.component_size(lower_width) * dst_size;
if (is_send_inst(split_inst))
data_size = align(data_size, REG_SIZE * reg_unit(s.devinfo));
unsigned comp_size =
split_inst->dst.component_size(lower_width);
split_inst->size_written = data_size + residency_size;
/* For SEND messages, align the data size to physical registers */
if (is_send_inst(split_inst))
comp_size = align(comp_size, REG_SIZE * reg_unit(s.devinfo));
split_inst->size_written = comp_size * dst_size + residency_size;
lbld.after(inst).emit(split_inst);
}