From d666a8d259a0bb0a14e5bf42e90f167e150f185b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Marek=20Ol=C5=A1=C3=A1k?= Date: Sat, 17 Jun 2023 14:55:00 -0400 Subject: [PATCH] ci: remove clang-format testing The way it's used is unacceptable. Here's the change it suggested: diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 05b9cb0a3f1..e58abfa885f 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -783,8 +783,7 @@ radv_CreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCr device->overallocation_disallowed = overallocation_disallowed; mtx_init(&device->overallocation_mutex, mtx_plain); - if (physical_device->rad_info.register_shadowing_required || - device->instance->debug_flags & RADV_DEBUG_SHADOW_REGS) + if (physical_device->rad_info.register_shadowing_required || device->instance->debug_flags & RADV_DEBUG_SHADOW_REGS) device->uses_shadow_regs = true; /* Create one context per queue priority. */ This is the dumbest reason to prevent merging a MR. I don't want to see this in projects I work on. Part-of: --- .gitlab-ci/test/gitlab-ci.yml | 18 ------------------ 1 file changed, 18 deletions(-) diff --git a/.gitlab-ci/test/gitlab-ci.yml b/.gitlab-ci/test/gitlab-ci.yml index 58ed67d8e78..d12bde95db3 100644 --- a/.gitlab-ci/test/gitlab-ci.yml +++ b/.gitlab-ci/test/gitlab-ci.yml @@ -30,24 +30,6 @@ rustfmt: - shopt -s globstar - rustfmt --check --verbose src/**/lib.rs -clang-format: - # Cancel job if a newer commit is pushed to the same branch - interruptible: true - stage: lint - extends: - - .use-debian/x86_64_build - - .lint-clang-format-rules - variables: - GIT_STRATEGY: fetch - LLVM_VERSION: 15 - script: - - shopt -s globstar - # We need a meson build dir, but its config doesn't actually matter, so - # let's just use the default. - - meson setup build - - ninja -C build clang-format - - git diff --color=always --exit-code # Fails if there are diffs - .test-gl: extends: - .test