From d62bb8bc0df66723fd9d5ccf2d04de2b50e76728 Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Wed, 31 Mar 2021 10:25:13 +1000 Subject: [PATCH] lavapipe: fail out if spirv->nir fails Just fail out earlier and assume a feature is missing. Fixes a crash in validation layer tests Reviewed-By: Mike Blumenkrantz Part-of: --- src/gallium/frontends/lavapipe/lvp_pipeline.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/gallium/frontends/lavapipe/lvp_pipeline.c b/src/gallium/frontends/lavapipe/lvp_pipeline.c index 671f336abf6..b158419ddde 100644 --- a/src/gallium/frontends/lavapipe/lvp_pipeline.c +++ b/src/gallium/frontends/lavapipe/lvp_pipeline.c @@ -485,6 +485,10 @@ lvp_shader_compile_to_ir(struct lvp_pipeline *pipeline, spec_entries, num_spec_entries, stage, entrypoint_name, &spirv_options, drv_options); + if (!nir) { + free(spec_entries); + return; + } nir_validate_shader(nir, NULL); free(spec_entries); @@ -753,6 +757,8 @@ lvp_graphics_pipeline_init(struct lvp_pipeline *pipeline, pCreateInfo->pStages[i].pName, stage, pCreateInfo->pStages[i].pSpecializationInfo); + if (!pipeline->pipeline_nir[stage]) + return VK_ERROR_FEATURE_NOT_PRESENT; } if (pipeline->pipeline_nir[MESA_SHADER_FRAGMENT]) { @@ -878,6 +884,8 @@ lvp_compute_pipeline_init(struct lvp_pipeline *pipeline, pCreateInfo->stage.pName, MESA_SHADER_COMPUTE, pCreateInfo->stage.pSpecializationInfo); + if (!pipeline->pipeline_nir[MESA_SHADER_COMPUTE]) + return VK_ERROR_FEATURE_NOT_PRESENT; lvp_pipeline_compile(pipeline, MESA_SHADER_COMPUTE); return VK_SUCCESS; }