fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-08 09:08:10 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

radv: disable IMAGE_USAGE_STORAGE with depth-only and stencil-only formats

Browse source 
This shouldn't have been enabled at all. Depth-stencil formats were
accidentally disabled but not depth-only or stencil-only formats.

This doesn't seem allowed by DX12 and both AMD/NVIDIA don't enable it.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23122>
(cherry picked from commit dda7400c0b)
This commit is contained in:
Samuel Pitoiset 2023-05-19 09:20:42 +02:00 • committed by Eric Engestrom
parent b8334c49fd
commit d61e376497
2 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -805,7 +805,7 @@
"description": "radv: disable IMAGE_USAGE_STORAGE with depth-only and stencil-only formats",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null
},

3
src/amd/vulkan/radv_formats.c
View file

@ -540,6 +540,9 @@ radv_is_storage_image_format_supported(struct radv_physical_device *physical_dev
if (format == VK_FORMAT_UNDEFINED)
return false;
if (vk_format_is_depth_or_stencil(format))
return false;
data_format =
radv_translate_tex_dataformat(format, desc, vk_format_get_first_non_void_channel(format));
num_format =