From d5208d9537b9fcea78aa4352113c4bd2453c2791 Mon Sep 17 00:00:00 2001 From: Mel Henning Date: Wed, 17 Dec 2025 18:02:04 -0500 Subject: [PATCH] nvk: Set maxStorageBufferRange = maxBufferSize We were previously reporting a larger maxStorageBufferRange than our maxBufferSize, which is weird. Lower maxStorageBufferRange to match maxBufferSize. Fixes crucible stress.limits.buffer-update.range.storage.q0 Fixes: 65f12fde4407 ("nvk: Improve address space and buffer size limits") Reviewed-by: Mary Guillemard Part-of: (cherry picked from commit c9ae59dec5a622fb3e3378515bd06f5e08466326) --- .pick_status.json | 2 +- src/nouveau/vulkan/nvk_physical_device.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 5e11948bc8f..e8bc05a4d3b 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -514,7 +514,7 @@ "description": "nvk: Set maxStorageBufferRange = maxBufferSize", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "65f12fde44075276b640925d4f4301fcf00fc955", "notes": null diff --git a/src/nouveau/vulkan/nvk_physical_device.c b/src/nouveau/vulkan/nvk_physical_device.c index 5374e991780..901bacb285f 100644 --- a/src/nouveau/vulkan/nvk_physical_device.c +++ b/src/nouveau/vulkan/nvk_physical_device.c @@ -768,7 +768,7 @@ nvk_get_device_properties(const struct nvk_instance *instance, .maxImageArrayLayers = 2048, .maxTexelBufferElements = 128 * 1024 * 1024, .maxUniformBufferRange = 65536, - .maxStorageBufferRange = UINT32_MAX, + .maxStorageBufferRange = 1ull << 31, .maxPushConstantsSize = NVK_MAX_PUSH_SIZE, .maxMemoryAllocationCount = 4096, .maxSamplerAllocationCount = 4000,