fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-03-11 00:30:44 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

i965/fs: Set LastRT on the final FB write on Broadwell.

Browse source 
In Piglit's EXT_framebuffer_multisample/alpha-to-coverage-dual-src-blend
test, key->nr_color_regions == 2, but the dual source blend FB write has
ir->target set to 0.  So we failed to set "Last Render Target Select" on
any FB write message.

We only emit one FB write per render target, so my comment about setting
LastRT on every FB write directed at the last color region is a bit...
misinformed.  According to the documentation, depth buffer writes and
scoreboard updates happen on the FB write with LastRT set, so I believe
we want to set it only once.

Signed-off-by: Kenneth Graunke <kenneth@whitecape.org>
Reviewed-by: Matt Turner <mattst88@gmail.com>
Cc: "10.2" <mesa-stable@lists.freedesktop.org>
This commit is contained in:
Kenneth Graunke 2014-07-21 16:17:46 -07:00
parent 36a4a6bbdc
commit d4d886a0bc
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/mesa/drivers/dri/i965/gen8_fs_generator.cpp
View file

@ -116,10 +116,8 @@ gen8_fs_generator::generate_fb_write(fs_inst *ir)
uint32_t msg_control = msg_type;
/* "Last Render Target Select" must be set on all writes to the last of
* the render targets (if using MRT), or always for a single RT scenario.
*/
if ((ir->target == key->nr_color_regions - 1) || !key->nr_color_regions)
/* Set "Last Render Target Select" on the final FB write. */
if (ir->eot)
msg_control |= (1 << 4); /* Last Render Target Select */
uint32_t surf_index =