fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-08 16:30:27 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panvk: Advertise support for VK_EXT_extended_dynamic_state[2]
Some checks are pending
macOS-CI / macOS-CI (dri) (push) Waiting to run
Details
macOS-CI / macOS-CI (xlib) (push) Waiting to run
Details

Browse source 
We added CmdBindVertexBuffers2(), the rest is handled by the core.

Advertising this feature also works around a CTS bug that was
calling CmdSetPatchControlPointsEXT() without checking for this
extension.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
Reviewed-by: Olivia Lee <benjamin.lee@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34696>
This commit is contained in:
Boris Brezillon 2025-04-23 16:39:13 +02:00
parent e3cbb2c131
commit d432fd9e32
6 changed files with 9 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
docs/features.txt
View file

@ -494,8 +494,8 @@ Vulkan 1.3 -- all DONE: anv, lvp, nvk, radv, tu, vn, v3dv
VK_KHR_synchronization2 DONE (anv, dzn, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn)
VK_KHR_zero_initialize_workgroup_memory DONE (anv, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn)
VK_EXT_4444_formats DONE (anv, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn)
VK_EXT_extended_dynamic_state DONE (anv, hasvk, lvp, nvk, radv, tu, v3dv, vn)
VK_EXT_extended_dynamic_state2 DONE (anv, hasvk, lvp, nvk, radv, tu, v3dv, vn)
VK_EXT_extended_dynamic_state DONE (anv, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn)
VK_EXT_extended_dynamic_state2 DONE (anv, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn)
VK_EXT_inline_uniform_block DONE (anv, hasvk, lvp, nvk, radv, tu, v3dv, vn)
VK_EXT_pipeline_creation_cache_control DONE (anv, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn)
VK_EXT_pipeline_creation_feedback DONE (anv, hasvk, lvp, nvk, panvk, radv, tu, v3dv, vn)

1
docs/relnotes/new_features.txt
View file

@ -9,3 +9,4 @@ dualSrcBlend on v3dv
VK_KHR_maintenance4 on panvk/v10+
VK_KHR_maintenance5 on panvk/v10+
VK_EXT_direct_mode_display on panvk
VK_EXT_extended_dynamic_state[2] on panvk

3
src/panfrost/ci/panfrost-g610-fails.txt
View file

@ -1,9 +1,6 @@
# uprev Piglit in Mesa
spec@ext_image_dma_buf_import@ext_image_dma_buf_import-refcount-multithread,Crash
# CTS bug, tries to use vkCmdSetPatchControlPointsEXT when we don't have that
dEQP-VK.pipeline.fast_linked_library.misc.interpolate_at_sample_no_sample_shading,Crash
dEQP-VK.renderpass.multiple_subpasses_multiple_command_buffers.test,Fail
dEQP-VK.glsl.loops.special.do_while_dynamic_iterations.dowhile_trap_vertex,Crash

3
src/panfrost/ci/panfrost-g720-fails.txt
View file

@ -1,9 +1,6 @@
# uprev Piglit in Mesa
spec@ext_image_dma_buf_import@ext_image_dma_buf_import-refcount-multithread,Crash
# CTS bug, tries to use vkCmdSetPatchControlPointsEXT when we don't have that
dEQP-VK.pipeline.fast_linked_library.misc.interpolate_at_sample_no_sample_shading,Crash
dEQP-VK.glsl.loops.special.do_while_dynamic_iterations.dowhile_trap_vertex,Crash
# Seems to be a precision issues because of floor fp16 being dropped since v11 (and the conversion done as a result)

3
src/panfrost/ci/panfrost-g725-fails.txt
View file

@ -1,9 +1,6 @@
# uprev Piglit in Mesa
spec@ext_image_dma_buf_import@ext_image_dma_buf_import-refcount-multithread,Crash
# CTS bug, tries to use vkCmdSetPatchControlPointsEXT when we don't have that
dEQP-VK.pipeline.fast_linked_library.misc.interpolate_at_sample_no_sample_shading,Crash
# Seems to be a precision issues because of floor fp16 being dropped since v11 (and the conversion done as a result)
dEQP-GLES3.functional.shaders.builtin_functions.common.fract.vec2_lowp_vertex,Fail
dEQP-GLES31.functional.shaders.builtin_functions.common.fract.vec2_lowp_compute,Fail

6
src/panfrost/vulkan/panvk_physical_device.c
View file

@ -283,6 +283,8 @@ get_device_extensions(const struct panvk_physical_device *device,
#ifdef VK_USE_PLATFORM_DISPLAY_KHR
.EXT_display_control = true,
#endif
.EXT_extended_dynamic_state = true,
.EXT_extended_dynamic_state2 = true,
.EXT_external_memory_dma_buf = true,
.EXT_global_priority = true,
.EXT_global_priority_query = true,
@ -460,6 +462,10 @@ get_features(const struct panvk_physical_device *device,
.robustImageAccess = true,
.inlineUniformBlock = false,
.descriptorBindingInlineUniformBlockUpdateAfterBind = false,
.extendedDynamicState = true,
.extendedDynamicState2 = true,
.extendedDynamicState2LogicOp = true,
.extendedDynamicState2PatchControlPoints = false,
.pipelineCreationCacheControl = true,
.privateData = true,
.shaderDemoteToHelperInvocation = false,