From d3ad9705dd9636ff9d415dccd99127aff5651b79 Mon Sep 17 00:00:00 2001 From: Eric Engestrom Date: Wed, 23 Jul 2025 10:31:06 +0200 Subject: [PATCH] ci: fix rustfmt job rules (one more case) f065c2f0ac9ab7563f82 actually always triggers the rule it adds because that commit itself changes one of these files, so the case where none of these files are changed was not actually tested. The two options are to drop the `changes:` line from that commit, to make every staging pipeline run that job, or to add the missing "no changes" corresponding rule, which this commit does, which aligns with the "run when files changed, don't run otherwise" behaviour of the other rules above. Fixes: f065c2f0ac9ab7563f82 ("ci: fix rustfmt job rules") Part-of: (cherry picked from commit f4166ab1e1d6dec2355c0d861c75319248d4de08) --- .gitlab-ci/test-source-dep.yml | 2 ++ .pick_status.json | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci/test-source-dep.yml b/.gitlab-ci/test-source-dep.yml index 89a6f0e8f0c..ea1392bd763 100644 --- a/.gitlab-ci/test-source-dep.yml +++ b/.gitlab-ci/test-source-dep.yml @@ -231,6 +231,8 @@ - if: $CI_PROJECT_NAMESPACE == "mesa" changes: *rustfmt_files allow_failure: true + - if: $CI_PROJECT_NAMESPACE == "mesa" + when: never - when: manual allow_failure: true diff --git a/.pick_status.json b/.pick_status.json index 06bc1664324..85c207b6086 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -4,7 +4,7 @@ "description": "ci: fix rustfmt job rules (one more case)", "nominated": true, "nomination_type": 2, - "resolution": 0, + "resolution": 1, "main_sha": null, "because_sha": "f065c2f0ac9ab7563f828484294c73092cf4d3b2", "notes": null