fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-02-01 11:10:27 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

panfrost: Inline pan_fbd_has_zs_crc_ext

Browse source 
It has a single user -- in a section of code that only runs for MFBD GPUs and
that has already decided whether to use CRCs -- so inlining it simplifies its
definition greatly and may avoid redeciding the CRC setting.

[Note for mesa-stable maintainers: This is not a bug fix but is marked for
backport so the next patch applies cleanly.]

Signed-off-by: Alyssa Rosenzweig <alyssa@collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16983>
(cherry picked from commit cac0578ee5)
This commit is contained in:
Alyssa Rosenzweig 2022-06-10 11:43:53 -04:00 • committed by Dylan Baker
parent e4da9d8254
commit d331e4edcd
3 changed files with 2 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.pick_status.json
View file

@ -175,7 +175,7 @@
"description": "panfrost: Inline pan_fbd_has_zs_crc_ext",
"nominated": true,
"nomination_type": 0,
"resolution": 0,
"resolution": 1,
"main_sha": null,
"because_sha": null
},

2
src/panfrost/lib/pan_cs.c
View file

@ -637,7 +637,7 @@ GENX(pan_emit_fbd)(const struct panfrost_device *dev,
unsigned tile_size;
unsigned internal_cbuf_size = pan_internal_cbuf_size(fb, &tile_size);
int crc_rt = GENX(pan_select_crc_rt)(fb);
bool has_zs_crc_ext = pan_fbd_has_zs_crc_ext(fb);
bool has_zs_crc_ext = (fb->zs.view.zs || fb->zs.view.s || crc_rt >= 0);
pan_section_pack(fbd, FRAMEBUFFER, PARAMETERS, cfg) {
#if PAN_ARCH >= 6

8
src/panfrost/lib/pan_cs.h
View file

@ -151,14 +151,6 @@ GENX(pan_emit_tls)(const struct pan_tls_info *info,
int
GENX(pan_select_crc_rt)(const struct pan_fb_info *fb);
static inline bool
pan_fbd_has_zs_crc_ext(const struct pan_fb_info *fb)
{
return PAN_ARCH >= 5 &&
(fb->zs.view.zs || fb->zs.view.s ||
GENX(pan_select_crc_rt)(fb) >= 0);
}
unsigned
GENX(pan_emit_fbd)(const struct panfrost_device *dev,
const struct pan_fb_info *fb,