fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2025-12-24 11:00:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

brw: Allow DPAS with BF on Gfx125

Browse source 
MTL doesn't support, but both ACM and ARL-H do.

Fixes: e384ccde28 ("brw: Expand EU validation for DPAS")
Reviewed-by: Rohan Garg <rohan.garg@intel.com>
Reviewed-by: Ian Romanick <ian.d.romanick@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/34506>
This commit is contained in:
Caio Oliveira 2025-03-28 16:36:45 -07:00 • committed by Marge Bot
parent 050acb9def
commit d1dd088ede
2 changed files with 10 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
src/intel/compiler/brw_eu_validate.c
View file

@ -2195,24 +2195,21 @@ instruction_restrictions(const struct brw_isa_info *isa,
if (brw_eu_inst_dpas_3src_exec_type(devinfo, inst->raw) ==
BRW_ALIGN1_3SRC_EXEC_TYPE_FLOAT) {
ERROR_IF(src1_type != BRW_TYPE_HF &&
src1_type != BRW_TYPE_BF,
"DPAS src1 type must be HF or BF.");
ERROR_IF(src2_type != BRW_TYPE_HF &&
src2_type != BRW_TYPE_BF,
"DPAS src2 type must be HF or BF.");
ERROR_IF(src1_type != src2_type,
"DPAS src1 and src2 with types must match when using float types.");
if (devinfo->ver < 20) {
ERROR_IF(src1_type != BRW_TYPE_HF,
"DPAS src1 type must be HF in Gfx12.");
ERROR_IF(src2_type != BRW_TYPE_HF,
"DPAS src2 type must be HF in Gfx12.");
ERROR_IF(dst_type != BRW_TYPE_F,
"DPAS destination type must be F in Gfx12.");
ERROR_IF(src0_type != BRW_TYPE_F,
"DPAS src0 type must be F in Gfx12.");
} else {
ERROR_IF(src1_type != BRW_TYPE_HF &&
src1_type != BRW_TYPE_BF,
"DPAS src1 type must be HF or BF in Gfx20+.");
ERROR_IF(src2_type != BRW_TYPE_HF &&
src2_type != BRW_TYPE_BF,
"DPAS src2 type must be HF or BF in Gfx20+.");
ERROR_IF(src1_type != src2_type,
"DPAS src1 and src2 with types must match when using float types.");
ERROR_IF(dst_type != BRW_TYPE_F &&
dst_type != src1_type,
"DPAS destination type must be F or match Src1/Src2 in Gfx20+.");

2
src/intel/compiler/test_eu_validate.cpp
View file

@ -3206,7 +3206,7 @@ TEST_P(validation_test, dpas_types)
TV( F, F, F, HF, false),
TV( F, F, HF, F, false),
TV( F, F, BF, BF, devinfo.ver >= 20),
TV( F, F, BF, BF, true),
TV(BF, BF, BF, BF, devinfo.ver >= 20),
TV(BF, F, BF, BF, devinfo.ver >= 20),
TV( F, BF, BF, BF, devinfo.ver >= 20),