fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-05 09:38:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

intel/decoder: Fix memory leak on error path

Browse source 
Fix defect reported by Coverity Scan.

Resource leak (RESOURCE_LEAK)
leaked_storage: Variable text_data going out of scope leaks the storage it points to.

Fixes: b4c8d2dc45 ("intel/decoder: Add intel_spec_load_common()")
Signed-off-by: Vinson Lee <vlee@freedesktop.org>
Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24659>
This commit is contained in:
Vinson Lee 2023-08-12 20:42:52 -07:00
parent 6a2a36d7dd
commit d0f4333fca
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/intel/common/intel_decoder.c
View file

@ -638,8 +638,10 @@ get_embedded_xml_data(int verx10, void **data, size_t *data_len)
assert(text_offset + text_length <= total_length);
*data = malloc(text_length);
if (*data == NULL)
if (*data == NULL) {
free(text_data);
return false;
}
memcpy(*data, &text_data[text_offset], text_length);
free(text_data);