From d0a95541fefdd334ae73b2bb4b30826bf5d3885e Mon Sep 17 00:00:00 2001 From: "Eric R. Smith" Date: Fri, 3 Jan 2025 19:23:31 -0400 Subject: [PATCH] panvk: re-enable fragmentStoresAndAtomics for v10 This feature actually worked, but accidentally triggered some CTS failures due do an unrelated sample_mask bug. That bug is fixed in the previous commits in this series, so re-enable fragmentStoresAndAtomics. There are two spurious CI failures created by this change; one is in a ycbcr test (which we're still working on) and the other is a CTS bug (it's using a feature we don't advertise). Reviewed-by: Mary Guillemard Reviewed-by: Boris Brezillon Part-of: --- src/panfrost/ci/panfrost-g610-fails.txt | 5 +++++ src/panfrost/vulkan/panvk_physical_device.c | 1 + 2 files changed, 6 insertions(+) diff --git a/src/panfrost/ci/panfrost-g610-fails.txt b/src/panfrost/ci/panfrost-g610-fails.txt index 9d6dfee2066..c9737cffa88 100644 --- a/src/panfrost/ci/panfrost-g610-fails.txt +++ b/src/panfrost/ci/panfrost-g610-fails.txt @@ -265,6 +265,9 @@ dEQP-VK.texture.filtering.3d.formats.d32_sfloat_s8_uint_stencil.d32_sfloat_s8_ui # CTS bug, see https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/5296 dEQP-VK.api.device_init.create_device_unsupported_features.protected_memory_features,Fail +# CTS bug, tries to use vkCmdSetPatchControlPointsEXT when we don't have that +dEQP-VK.pipeline.fast_linked_library.misc.interpolate_at_sample_no_sample_shading,Crash + # CTS bug, works fine if Vulkan 1.1 is forced dEQP-VK.api.device_init.create_device_global_priority.basic,Fail dEQP-VK.api.device_init.create_device_global_priority_khr.basic,Fail @@ -292,6 +295,8 @@ dEQP-VK.glsl.loops.special.do_while_dynamic_iterations.dowhile_trap_vertex,Crash dEQP-VK.rasterization.rasterization_order_attachment_access.depth.samples_1.multi_draw_barriers,Crash dEQP-VK.rasterization.rasterization_order_attachment_access.stencil.samples_1.multi_draw_barriers,Crash +dEQP-VK.ycbcr.query.lod.fragment.r8g8b8a8_unorm,Fail + dEQP-VK.wsi.wayland.swapchain.simulate_oom.composite_alpha,Crash dEQP-VK.wsi.wayland.swapchain.simulate_oom.exclusive_nonzero_queues,Crash dEQP-VK.wsi.wayland.swapchain.simulate_oom.image_array_layers,Crash diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index bfa6a10a24e..05b7c547bca 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -273,6 +273,7 @@ get_features(const struct panvk_physical_device *device, .samplerAnisotropy = true, .textureCompressionETC2 = true, .textureCompressionASTC_LDR = true, + .fragmentStoresAndAtomics = arch >= 10, .shaderUniformBufferArrayDynamicIndexing = true, .shaderSampledImageArrayDynamicIndexing = true, .shaderStorageBufferArrayDynamicIndexing = true,