fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-05-06 11:38:05 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

broadcom/compiler: don't favor/select accum registers for hw not supporting it

Browse source 
Note that what we do is to just return false on the favor/select accum
methods. We could just avoid to call them, but as the select is called
more than once, it is just easier this way.

Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/25450>
This commit is contained in:
Alejandro Piñeiro 2021-09-17 01:07:06 +02:00 • committed by Marge Bot
parent 1260b202be
commit d00f7ef23e
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/broadcom/compiler/vir_register_allocate.c
View file

@ -797,6 +797,9 @@ v3d_ra_favor_accum(struct v3d_ra_select_callback_data *v3d_ra,
BITSET_WORD *regs, BITSET_WORD *regs,
int priority) int priority)
{ {
if (!v3d_ra->devinfo->has_accumulators)
return false;
/* Favor accumulators if we have less that this number of physical /* Favor accumulators if we have less that this number of physical
* registers. Accumulators have more restrictions (like being * registers. Accumulators have more restrictions (like being
* invalidated through thrsw), so running out of physical registers * invalidated through thrsw), so running out of physical registers
@ -832,6 +835,9 @@ v3d_ra_select_accum(struct v3d_ra_select_callback_data *v3d_ra,
BITSET_WORD *regs, BITSET_WORD *regs,
unsigned int *out) unsigned int *out)
{ {
if (!v3d_ra->devinfo->has_accumulators)
return false;
/* Choose r5 for our ldunifs if possible (nobody else can load to that /* Choose r5 for our ldunifs if possible (nobody else can load to that
* reg, and it keeps the QPU cond field free from being occupied by * reg, and it keeps the QPU cond field free from being occupied by
* ldunifrf). * ldunifrf).