fdo-mirrors/mesa
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/mesa/mesa.git synced 2026-01-21 06:30:36 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

asahi: Don't crash on VBOs without resources

Browse source 
There's a Firefox QuakeJS heisenbug that triggers this sometimes, by
binding vertex attributes with no buffer...

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Signed-off-by: Asahi Lina <lina@asahilina.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/20365>
This commit is contained in:
Asahi Lina 2022-12-07 21:43:43 +09:00 • committed by Marge Bot
parent 331c2f4b7e
commit cea15fe06d
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/gallium/drivers/asahi/agx_uniforms.c
View file

@ -75,6 +75,11 @@ agx_push_location_direct(struct agx_batch *batch, struct agx_push push,
struct pipe_vertex_buffer vb = ctx->vertex_buffers[push.vbo];
assert(!vb.is_user_buffer);
if (!vb.buffer.resource) {
*address = 0;
return ptr.gpu;
}
struct agx_resource *rsrc = agx_resource(vb.buffer.resource);
agx_batch_reads(batch, rsrc);